Repository navigation
[AudioToolbox] Bind music device selectors. Fixes #12490 - #27039
rolfbjarne wants to merge 2 commits into
Conversation
Expose the music device selector constants as MusicDeviceSelector, including the range marker and MIDI event-list selector. Match the values in MusicDevice.h and document each member without introducing unrelated music device APIs. Add parameterized regression coverage for all eight selector values. Fixes #12490. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 834f092e-f43a-4f1e-b980-12734e1d1f0a
Remove MusicDeviceSelectorTest as requested: enum constants do not need dedicated tests. Keep the documented selector binding unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 834f092e-f43a-4f1e-b980-12734e1d1f0a
There was a problem hiding this comment.
🔵 Needs a closer look
Validation of the new public API remains incomplete because build, test, and API-diff checks are reported as pending.
No open issues 🎉
What changed in this PR
Adds AudioToolbox.MusicDeviceSelector to expose the missing low-level Audio Unit dispatch constants requested in #12490, without changing existing managed APIs.
Changes:
- Adds the selector-range marker and seven operation selectors.
- Documents the enum and each member; intentionally omits dedicated enum-value tests.
| File | Description |
|---|---|
src/AudioToolbox/Enums.cs |
Adds the documented MusicDeviceSelector enum and its constants. |
Review effort: Balanced
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🔥 [CI Build #5397507] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 6 tests failed, 211 tests passed. Failures❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)4 tests failed, 16 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests1 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Expose the missing
kMusicDevice*selector constants asAudioToolbox.MusicDeviceSelector, including the selector-range marker and all seven operation selectors. The values matchMusicDevice.h, and each member has XML documentation.These constants identify low-level Audio Unit dispatch operations; they are not MIDI status bytes or Audio Unit property IDs. Existing managed APIs therefore remain unchanged. Dedicated enum-value tests are intentionally omitted.
Fixes #12490
🤖 Pull request created by Copilot