Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf_BigInteger performance test case name is too long #4409

Open
caaavik-msft opened this issue Aug 21, 2024 · 0 comments
Open

Perf_BigInteger performance test case name is too long #4409

caaavik-msft opened this issue Aug 21, 2024 · 0 comments

Comments

@caaavik-msft
Copy link
Contributor

In the Perf_BigInteger benchmark, we have some arguments with long strings, with one being 20,000 characters long:

yield return new BigIntegerData(string.Concat(Enumerable.Repeat("1234567890", 20)));
yield return new BigIntegerData(string.Concat(Enumerable.Repeat("1234567890", 2000)));
yield return new BigIntegerData(string.Concat(Enumerable.Repeat("1234567890", 1000)) + new string('0', 10000));

The whole string argument here is being included in the test name, and we are truncating test names at 200 characters in our report URLs, so each case is going to have the same report URL. The full test name is still included in our raw data, it just means that we can't distinguish them in our generated reports and graphs as we won't know which test case the report is displaying the data for. Either we need to change how we do our report URL truncation (maybe for >200 characters we put a small hash at the end), or modify this benchmark to not take the full string as a direct argument, but rather a string that describes the type of string being processed which it can lookup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant