Remove unnecessary variable assignments (#10428)

Author: jjonescz

.globalconfig

@@ -0,0 +1,4 @@
+is_global = true
+
+# IDE0059: Remove unnecessary value assignment
+dotnet_diagnostic.IDE0059.severity = warning

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/MapCode/MapCodeEndpoint.cs

@@ -76,7 +76,7 @@ public void ApplyCapabilities(VSInternalServerCapabilities serverCapabilities, V
     }
 
     private async Task<WorkspaceEdit?> HandleMappingsAsync(VSInternalMapCodeMapping[] mappings, Guid mapCodeCorrelationId, CancellationToken cancellationToken)
-    { 
+    {
         using var _ = ArrayBuilderPool<TextDocumentEdit>.GetPooledObject(out var changes);
         foreach (var mapping in mappings)
         {
@@ -316,7 +316,7 @@ private async Task<bool> TrySendCSharpDelegatedMappingRequestAsync(
             [nodeToMap.ToFullString()],
             FocusLocations: focusLocations);
 
-        WorkspaceEdit? edits = null;
+        WorkspaceEdit? edits;
         try
         {
             edits = await _clientConnection.SendRequestAsync<DelegatedMapCodeParams, WorkspaceEdit?>(

src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Serialization/MessagePack/Formatters/RazorConfigurationFormatter.cs

@@ -25,11 +25,9 @@ public override RazorConfiguration Deserialize(ref MessagePackReader reader, Ser
 
         count -= 2;
 
-        var forceRuntimeCodeGeneration = false;
-
         if (reader.NextMessagePackType is MessagePackType.Boolean)
         {
-            forceRuntimeCodeGeneration = reader.ReadBoolean();
+            reader.ReadBoolean(); // forceRuntimeCodeGeneration
             count -= 1;
         }
 

src/Razor/src/Microsoft.VisualStudio.LanguageServer.ContainedLanguage/DefaultLSPRequestInvoker.cs

@@ -81,7 +81,6 @@ public override async Task<ReinvokeResponse<TOut>> ReinvokeRequestOnServerAsync<
             throw new ArgumentException("message", nameof(method));
         }
 
-        var serializedParams = JToken.FromObject(parameters);
         var response = await _languageServiceBroker.RequestAsync(
             new GeneralRequest<TIn, TOut> { LanguageServerName = languageServerName, Method = method, Request = parameters },
             cancellationToken);

src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Language/IntegrationTests/IntegrationTestBase.cs

@@ -177,7 +177,6 @@ protected RazorProjectItem CreateProjectItemFromFile(string? filePath = null, st
             throw new XunitException($"The resource {sourceFileName} was not found.");
         }
         var fileContent = testFile.ReadAllText();
-        var normalizedContent = NormalizeNewLines(fileContent);
 
         var workingDirectory = Path.GetDirectoryName(fileName);
         var fullPath = sourceFileName;

src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Language/IntegrationTests/RazorBaselineIntegrationTestBase.cs

@@ -235,7 +235,6 @@ private string GetBaselineFilePath(RazorCodeDocument codeDocument, string extens
 
     private static void WriteBaseline(string text, string filePath)
     {
-        var lines = text.Replace("\r", "").Replace("\n", "\r\n");
         File.WriteAllText(filePath, text, _baselineEncoding);
     }