Skip to content

Commit e4c69c8

Browse files
Clean up ProjectConfigurationStateSynchronizer a bit
1 parent 094e243 commit e4c69c8

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/ProjectConfigurationStateSynchronizer.cs

+10-8
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,11 @@ namespace Microsoft.AspNetCore.Razor.LanguageServer;
2020

2121
internal class ProjectConfigurationStateSynchronizer : IProjectConfigurationFileChangeListener
2222
{
23-
private readonly ProjectSnapshotManagerDispatcher _projectSnapshotManagerDispatcher;
23+
private readonly ProjectSnapshotManagerDispatcher _dispatcher;
2424
private readonly IRazorProjectService _projectService;
25-
private readonly LanguageServerFeatureOptions _languageServerFeatureOptions;
25+
private readonly LanguageServerFeatureOptions _options;
2626
private readonly ILogger _logger;
27+
2728
private readonly Dictionary<string, ProjectKey> _configurationToProjectMap;
2829
internal readonly Dictionary<ProjectKey, DelayedProjectInfo> ProjectInfoMap;
2930

@@ -33,10 +34,11 @@ public ProjectConfigurationStateSynchronizer(
3334
ILoggerFactory loggerFactory,
3435
LanguageServerFeatureOptions languageServerFeatureOptions)
3536
{
36-
_projectSnapshotManagerDispatcher = projectSnapshotManagerDispatcher;
37+
_dispatcher = projectSnapshotManagerDispatcher;
3738
_projectService = projectService;
38-
_languageServerFeatureOptions = languageServerFeatureOptions;
39+
_options = languageServerFeatureOptions;
3940
_logger = loggerFactory.GetOrCreateLogger<ProjectConfigurationStateSynchronizer>();
41+
4042
_configurationToProjectMap = new Dictionary<string, ProjectKey>(FilePathComparer.Instance);
4143
ProjectInfoMap = new Dictionary<ProjectKey, DelayedProjectInfo>();
4244
}
@@ -50,14 +52,14 @@ public void ProjectConfigurationFileChanged(ProjectConfigurationFileChangeEventA
5052
throw new ArgumentNullException(nameof(args));
5153
}
5254

53-
_projectSnapshotManagerDispatcher.AssertRunningOnDispatcher();
55+
_dispatcher.AssertRunningOnDispatcher();
5456

5557
switch (args.Kind)
5658
{
5759
case RazorFileChangeKind.Changed:
5860
{
5961
var configurationFilePath = FilePathNormalizer.Normalize(args.ConfigurationFilePath);
60-
if (!args.TryDeserialize(_languageServerFeatureOptions, out var projectInfo))
62+
if (!args.TryDeserialize(_options, out var projectInfo))
6163
{
6264
if (!_configurationToProjectMap.TryGetValue(configurationFilePath, out var lastAssociatedProjectKey))
6365
{
@@ -93,7 +95,7 @@ public void ProjectConfigurationFileChanged(ProjectConfigurationFileChangeEventA
9395
case RazorFileChangeKind.Added:
9496
{
9597
var configurationFilePath = FilePathNormalizer.Normalize(args.ConfigurationFilePath);
96-
if (!args.TryDeserialize(_languageServerFeatureOptions, out var projectInfo))
98+
if (!args.TryDeserialize(_options, out var projectInfo))
9799
{
98100
// Given that this is the first time we're seeing this configuration file if we can't deserialize it
99101
// then we have to noop.
@@ -177,7 +179,7 @@ async Task UpdateAfterDelayAsync(ProjectKey projectKey, CancellationToken cancel
177179
// ConfigureAwait(true) to make sure we are still running in ProjectSnapshotManagerDispatcher context
178180
await Task.Delay(EnqueueDelay).ConfigureAwait(true);
179181

180-
_projectSnapshotManagerDispatcher.AssertRunningOnDispatcher();
182+
_dispatcher.AssertRunningOnDispatcher();
181183

182184
var delayedProjectInfo = ProjectInfoMap[projectKey];
183185
await UpdateProjectAsync(projectKey, delayedProjectInfo.ProjectInfo, cancellationToken).ConfigureAwait(false);

0 commit comments

Comments
 (0)