Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSbuildProjectLoader.LoadProjectInfoAsync should allow skipping unrecognized projects #75956

Open
tmat opened this issue Nov 18, 2024 · 0 comments
Open

MSbuildProjectLoader.LoadProjectInfoAsync should allow skipping unrecognized projects #75956

tmat opened this issue Nov 18, 2024 · 0 comments
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@tmat
Copy link
Member

tmat commented Nov 18, 2024 •
edited
Loading

LoadSolutionInfoAsync uses SkipUnrecognizedProjects property to determine whether to throw on unrecognized project.
LoadProjectInfoAsync uses that property as well, but only for discovered projects. It is hardcoded to throw exception when requested projects are unrecognized.

The caller needs to handle unrecognized projects in two ways:

  • hook up WorkspaceFailed
  • catch a general InvalidOperationException around the entire load call

It'd be better if LoadProjectInfoAsync honored SkipUnrecognizedProjects for all projects. IF the requested project is not recognized it'd return empty array.

Related: #75170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmat