OverloadResolutionPriority is not respected on some attribute constructors

[AlekseyTs]

The unit-tests reflect the current behavior:

    [Fact]
    public void CycleOnOverloadResolutionPriorityConstructor_07()
    {
        var source = """
            using System.Runtime.CompilerServices;

            namespace System
            {
                public class ObsoleteAttribute : Attribute
                {
                    public ObsoleteAttribute(string x){}

                    [OverloadResolutionPriority(1)]
                    public ObsoleteAttribute(string x, bool y = false){}

                }
            }

            #pragma warning disable CS0436 // The type 'ObsoleteAttribute' in '' conflicts with the imported type 'ObsoleteAttribute'

            [System.Obsolete("Test")]
            public class C {}
            
            public class D
            {
                public C x;
            }
            """;

        var verifier = CompileAndVerify([source, OverloadResolutionPriorityAttributeDefinition],
            symbolValidator: (m) =>
            {
                AssertEx.Equal("System.ObsoleteAttribute..ctor(System.String x)",
                               m.ContainingAssembly.GetTypeByMetadataName("C")!.GetAttributes().Single().AttributeConstructor.ToTestDisplayString());
            });
        verifier.VerifyDiagnostics(
            // (22,12): warning CS0618: 'C' is obsolete: 'Test'
            //     public C x;
            Diagnostic(ErrorCode.WRN_DeprecatedSymbolStr, "C").WithArguments("C", "Test").WithLocation(22, 12)
            );
    }

    [Fact]
    public void CycleOnOverloadResolutionPriorityConstructor_08()
    {
        var source = """
            using System.Runtime.CompilerServices;

            namespace System
            {
                public class ObsoleteAttribute : Attribute
                {
                    public ObsoleteAttribute(string x){}

                    [OverloadResolutionPriority(1)]
                    public ObsoleteAttribute(string x, bool y = true){}

                }
            }

            #pragma warning disable CS0436 // The type 'ObsoleteAttribute' in '' conflicts with the imported type 'ObsoleteAttribute'

            [System.Obsolete("Test")]
            public class C {}
            
            public class D
            {
                public C x;
            }
            """;

        var verifier = CompileAndVerify([source, OverloadResolutionPriorityAttributeDefinition],
            symbolValidator: (m) =>
            {
                AssertEx.Equal("System.ObsoleteAttribute..ctor(System.String x)",
                               m.ContainingAssembly.GetTypeByMetadataName("C")!.GetAttributes().Single().AttributeConstructor.ToTestDisplayString());
            });
        verifier.VerifyDiagnostics(
            // (22,12): warning CS0618: 'C' is obsolete: 'Test'
            //     public C x;
            Diagnostic(ErrorCode.WRN_DeprecatedSymbolStr, "C").WithArguments("C", "Test").WithLocation(22, 12)
            );
    }

Observed:
[System.Obsolete("Test")] binds to System.ObsoleteAttribute..ctor(System.String x)

Expected:
[System.Obsolete("Test")] binds to System.ObsoleteAttribute..ctor(System.String x, System.Boolean y)

[AlekseyTs]

@333fred FYI

[333fred]

Yes, that's the behavior I expected to see.

roslyn/src/Compilers/CSharp/Portable/Binder/Semantics/OverloadResolution/OverloadResolution.cs

Line 1746 in d88be6d

if (!isEarlyAttributeBinding)

talks about this, and points to the test that shows the behavior.

[AlekseyTs]

Yes, that's the behavior I expected to see.

I don't think it has to be this way though. That is why I opened the issue. We can talk offline in more details.