-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify breaking-change rules for properties #112368
Comments
Related: #29637 |
It might also be good to mention nested types for clarity, since "members" of a type can include types. I would assume it's a breaking change to move a nested type to be nested in |
Tagging subscribers to this area: @dotnet/area-meta |
It should be fine to move properties from a derived type to a base type. |
In that case the package validation tools are broken |
Would moving a public property up to a base class be considered a breaking change, in any sense?
The breaking-change-rules doc mentions that moving methods up is allowed. It seems like moving properties should be allowed too. But the Microsoft.DotNet.PackageValidation tool flags this as a breaking change.
And while we're at it, how about public events and indexers?
It would be good to get a definitive answer, and to have the doc and the validation tool in sync as well.
@jnm2 @stephentoub
The text was updated successfully, but these errors were encountered: