From 274b284efb2a66571e422faddb1f0203f79f59be Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 8 Jan 2026 07:22:21 +0000 Subject: [PATCH 1/3] Initial plan From 4e0c397bfa1d5a7e2daa127a55e8ecfa8a325cd2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 8 Jan 2026 07:50:28 +0000 Subject: [PATCH 2/3] Remove GetFullName(DefType) extension method and replace usages Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> --- .../tools/Common/TypeSystem/Common/TypeSystemHelpers.cs | 9 +-------- src/coreclr/tools/Common/TypeSystem/Ecma/EcmaType.cs | 2 +- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs b/src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs index 7db13bc8bc862c..ccac34c2d288f0 100644 --- a/src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs +++ b/src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs @@ -157,14 +157,7 @@ public static MethodDesc FindMethodOnTypeWithMatchingTypicalMethod(this TypeDesc return null; } - /// - /// Retrieves the namespace qualified name of a . - /// - public static ReadOnlySpan GetFullName(this DefType metadataType) - { - ReadOnlySpan ns = metadataType.Namespace; - return ns.Length > 0 ? ns.Append("."u8, metadataType.Name) : metadataType.Name; - } + /// /// Retrieves all methods on a type, including the ones injected by the type system context. diff --git a/src/coreclr/tools/Common/TypeSystem/Ecma/EcmaType.cs b/src/coreclr/tools/Common/TypeSystem/Ecma/EcmaType.cs index af49544682311c..2abdab970b83ac 100644 --- a/src/coreclr/tools/Common/TypeSystem/Ecma/EcmaType.cs +++ b/src/coreclr/tools/Common/TypeSystem/Ecma/EcmaType.cs @@ -419,7 +419,7 @@ public override MethodDesc GetFinalizer() if (impl == null) { // TODO: invalid input: the type doesn't derive from our System.Object - throw new TypeLoadException(System.Text.Encoding.UTF8.GetString(this.GetFullName())); + ThrowHelper.ThrowTypeLoadException(this); } if (impl.OwningType != objectType) From a99abf8ef6779f53302547531a9ed8c31b7dcf90 Mon Sep 17 00:00:00 2001 From: Jan Kotas Date: Thu, 8 Jan 2026 23:12:00 -0800 Subject: [PATCH 3/3] Update src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs --- src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs b/src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs index ccac34c2d288f0..931983a7245ae5 100644 --- a/src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs +++ b/src/coreclr/tools/Common/TypeSystem/Common/TypeSystemHelpers.cs @@ -157,8 +157,6 @@ public static MethodDesc FindMethodOnTypeWithMatchingTypicalMethod(this TypeDesc return null; } - - /// /// Retrieves all methods on a type, including the ones injected by the type system context. ///