Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT-LLVM] Non hybrid globalization requires JS #2557

Open
yowl opened this issue Apr 23, 2024 · 6 comments
Open

[NativeAOT-LLVM] Non hybrid globalization requires JS #2557

yowl opened this issue Apr 23, 2024 · 6 comments

Comments

@yowl
Copy link
Contributor

yowl commented Apr 23, 2024

With dotnet/runtime#99956, globalization requires some JS which we wont have for WASI and don't include in the build #2543 (comment). We should do something else, use the full ICU as before, in the future maybe WebAssembly/WASI#590

@maraf
Copy link
Member

maraf commented Apr 23, 2024

@ilonatommy How is globalization working on WASI on Mono?

@ilonatommy
Copy link
Member

WASI does not expose Intl API in the same way as browser does, so it's not possible to implement HG there. There are ongoing discussions under WebAssembly/WASI#239 or WebAssembly/WASI#25 mentioning the need to enable it.

@maraf
Copy link
Member

maraf commented Apr 23, 2024

The issue explicitly mentions non HG. Do we require JS in non HG or is this issue missleading?

@ilonatommy
Copy link
Member

Sorry, misread it. Issue is formed correctly. For NativeName to return correct value we need JS (so HG switched on). Otherwise, we use ICU data that is shipped in reduced size form- without full NativeName info. Theoretically we could start adding that info and pump-up ICU package but already long time ago it was decided against it. I am not sure what is the size change and if custom ICU build would help here, I will need to check it. Beyond that I don't see any "easy" existing solution.

@maraf
Copy link
Member

maraf commented Apr 23, 2024

IIUC on WASI we don't correctly compute NativeName, is that right?

@ilonatommy
Copy link
Member

ilonatommy commented Apr 23, 2024

IIUC on WASI we don't correctly compute NativeName, is that right?

We return e.g. en-US when the expectation is English (United States). See the original issues about it: dotnet/runtime#44739.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants