Remove RunSettingsFilePath support from dotnet test for MTP

Author: Youssef1313

src/Cli/dotnet/commands/dotnet-test/CliConstants.cs

@@ -41,7 +41,6 @@ internal static class CliConstants
 
     public const string BinLogFileName = "msbuild.binlog";
 
-    public const string TestingPlatformVsTestBridgeRunSettingsFileEnvVar = "TESTINGPLATFORM_VSTESTBRIDGE_RUNSETTINGS_FILE";
     public const string DLLExtension = ".dll";
 
     public const string MTPTarget = "_MTPBuild";
@@ -91,7 +90,6 @@ internal static class ProjectProperties
     internal const string TargetFrameworks = "TargetFrameworks";
     internal const string TargetPath = "TargetPath";
     internal const string ProjectFullPath = "MSBuildProjectFullPath";
-    internal const string RunSettingsFilePath = "RunSettingsFilePath";
     internal const string RunCommand = "RunCommand";
     internal const string RunArguments = "RunArguments";
     internal const string RunWorkingDirectory = "RunWorkingDirectory";

src/Cli/dotnet/commands/dotnet-test/IPC/Models/ModuleMessage.cs

@@ -3,4 +3,4 @@
 
 namespace Microsoft.DotNet.Tools.Test;
 
-internal sealed record ModuleMessage(string? DllOrExePath, string? ProjectPath, string? TargetFramework, string? RunSettingsFilePath, string IsTestingPlatformApplication) : IRequest;
+internal sealed record ModuleMessage(string? DllOrExePath, string? ProjectPath, string? TargetFramework, string IsTestingPlatformApplication) : IRequest;

src/Cli/dotnet/commands/dotnet-test/IPC/Serializers/ModuleMessageSerializer.cs

@@ -12,17 +12,15 @@ public object Deserialize(Stream stream)
         string modulePath = ReadString(stream);
         string projectPath = ReadString(stream);
         string targetFramework = ReadString(stream);
-        string runSettingsFilePath = ReadString(stream);
         string isTestingPlatformApplication = ReadString(stream);
-        return new ModuleMessage(modulePath.Trim(), projectPath.Trim(), targetFramework.Trim(), runSettingsFilePath.Trim(), isTestingPlatformApplication.Trim());
+        return new ModuleMessage(modulePath.Trim(), projectPath.Trim(), targetFramework.Trim(), isTestingPlatformApplication.Trim());
     }
 
     public void Serialize(object objectToSerialize, Stream stream)
     {
         WriteString(stream, ((ModuleMessage)objectToSerialize).DllOrExePath);
         WriteString(stream, ((ModuleMessage)objectToSerialize).ProjectPath);
         WriteString(stream, ((ModuleMessage)objectToSerialize).TargetFramework);
-        WriteString(stream, ((ModuleMessage)objectToSerialize).RunSettingsFilePath);
         WriteString(stream, ((ModuleMessage)objectToSerialize).IsTestingPlatformApplication);
     }
 }

src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs

@@ -162,7 +162,6 @@ private void LogProjectProperties(IEnumerable<TestModule> modules)
             logMessageBuilder.AppendLine($"{ProjectProperties.RunCommand}: {module.RunProperties.RunCommand}");
             logMessageBuilder.AppendLine($"{ProjectProperties.RunArguments}: {module.RunProperties.RunArguments}");
             logMessageBuilder.AppendLine($"{ProjectProperties.RunWorkingDirectory}: {module.RunProperties.RunWorkingDirectory}");
-            logMessageBuilder.AppendLine($"{ProjectProperties.RunSettingsFilePath}: {module.RunSettingsFilePath}");
             logMessageBuilder.AppendLine();
         }
 

src/Cli/dotnet/commands/dotnet-test/Models.cs

@@ -3,7 +3,7 @@
 
 namespace Microsoft.DotNet.Cli;
 
-internal sealed record TestModule(RunProperties RunProperties, string? ProjectFullPath, string? TargetFramework, string? RunSettingsFilePath, bool IsTestingPlatformApplication, bool IsTestProject);
+internal sealed record TestModule(RunProperties RunProperties, string? ProjectFullPath, string? TargetFramework, bool IsTestingPlatformApplication, bool IsTestProject);
 
 internal sealed record Handshake(Dictionary<byte, string>? Properties);
 

src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs

@@ -163,9 +163,8 @@ public static IEnumerable<TestModule> GetProjectProperties(string projectFilePat
         string targetFramework = project.GetPropertyValue(ProjectProperties.TargetFramework);
         RunProperties runProperties = GetRunProperties(project, loggers);
         string projectFullPath = project.GetPropertyValue(ProjectProperties.ProjectFullPath);
-        string runSettingsFilePath = project.GetPropertyValue(ProjectProperties.RunSettingsFilePath);
 
-        return new TestModule(runProperties, PathUtility.FixFilePath(projectFullPath), targetFramework, runSettingsFilePath, isTestingPlatformApplication, isTestProject);
+        return new TestModule(runProperties, PathUtility.FixFilePath(projectFullPath), targetFramework, isTestingPlatformApplication, isTestProject);
 
         static RunProperties GetRunProperties(ProjectInstance project, ICollection<ILogger>? loggers)
         {

src/Cli/dotnet/commands/dotnet-test/TestApplication.cs

@@ -79,8 +79,6 @@ private ProcessStartInfo CreateProcessStartInfo(bool isDll, TestOptions testOpti
             processStartInfo.WorkingDirectory = _module.RunProperties.RunWorkingDirectory;
         }
 
-        AddRunSettingsFileToEnvironment(processStartInfo);
-
         return processStartInfo;
     }
 
@@ -99,14 +97,6 @@ private string GetArguments(TestOptions testOptions, bool isDll)
         return BuildArgsWithDotnetRun(testOptions);
     }
 
-    private void AddRunSettingsFileToEnvironment(ProcessStartInfo processStartInfo)
-    {
-        if (!string.IsNullOrEmpty(_module.RunSettingsFilePath))
-        {
-            processStartInfo.EnvironmentVariables.Add(CliConstants.TestingPlatformVsTestBridgeRunSettingsFileEnvVar, _module.RunSettingsFilePath);
-        }
-    }
-
     private static bool IsArchitectureSpecified(TestOptions testOptions)
     {
         return !string.IsNullOrEmpty(testOptions.Architecture);

src/Cli/dotnet/commands/dotnet-test/TestModulesFilterHandler.cs

@@ -53,7 +53,7 @@ public bool RunWithTestModulesFilter(ParseResult parseResult, BuildOptions build
 
         foreach (string testModule in testModulePaths)
         {
-            var testApp = new TestApplication(new TestModule(new RunProperties(testModule, null, null), null, null, null, true, true), buildOptions);
+            var testApp = new TestApplication(new TestModule(new RunProperties(testModule, null, null), null, null, true, true), buildOptions);
             // Write the test application to the channel
             _actionQueue.Enqueue(testApp);
         }