Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bundling NativeAOT NuGet packages from runtime on non-vmr builds. #41687

Open
tmds opened this issue Jun 20, 2024 · 0 comments
Open

Enable bundling NativeAOT NuGet packages from runtime on non-vmr builds. #41687

tmds opened this issue Jun 20, 2024 · 0 comments
Labels
Area-NetSDK untriaged Request triage from a team member

Comments

@tmds
Copy link
Member

tmds commented Jun 20, 2024

The NativeAOT bundeling added in #41198 is copying NuGet packages directly from the runtime repo build output:

<BundledLayoutLibraryPackage Include="$(SourceBuiltShippingPackagesDir)/../runtime/Microsoft.DotNet.ILCompiler.$(MicrosoftNETCoreAppRuntimePackageVersion).nupkg" Condition="'$(BundleNativeAotCompiler)' == 'true'" />
<BundledLayoutLibraryPackage Include="$(SourceBuiltShippingPackagesDir)/../runtime/Microsoft.NET.ILLink.Tasks.$(MicrosoftNETILLinkTasksPackageVersion).nupkg" Condition="'$(BundleNativeAotCompiler)' == 'true'" />

This location is not available when the SDK is built outside of the vmr.

This issue is for replacing that copy with obtaining the packages through a NuGet source. See #41198 (comment).

When this is working the, the DotNetBuildOrchestrator condition can be removed here:

<!-- DotNetBuildOrchestrator is (currently) needed in order to obtain NuGet packages from the runtime build. -->
<BundleNativeAotCompiler Condition="'$(BundleNativeAotCompiler)' == '' and '$(DotNetBuildSourceOnly)' == 'true' and '$(SourceBuildUseMonoRuntime)' != 'true' and '$(DotNetBuildOrchestrator)' == 'true'">true</BundleNativeAotCompiler>

cc @ViktorHofer

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

1 participant