Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stage 2 and other non-MSFT builds in main #4605

Open
NikolaMilosavljevic opened this issue Sep 13, 2024 · 0 comments · May be fixed by dotnet/sdk#44959
Open

Enable stage 2 and other non-MSFT builds in main #4605

NikolaMilosavljevic opened this issue Sep 13, 2024 · 0 comments · May be fixed by dotnet/sdk#44959
Assignees
Labels
area-build Improvements in source-build's own build process

Comments

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Sep 13, 2024

All non-MSFT (including stage 2) builds were disabled with dotnet/sdk#43439

We've disabled them to resolve #4586

Stage 2 builds were failing as is always the case during transition to a new release. The failures were originally introduced with dotnet/sdk#42969. We could have modified those properties, to enable PVP version flow, and get stage 2 builds running, but that would have only worked for a short time, until runtime and aspnetcore moved to 10.0 versioning. At that point building 9.0 projects could break, as _NET90RuntimePackVersion and other 9.0 'packs' properties in src/Installer/redist-installer/targets/GenerateBundledVersions.targets would reference 10.0 'packs'.

Other non-MSFT builds were disabled even though they were passing at the moment - however, the very next re-bootstrapping in main would have broken those.

All non-MSFT builds can be enabled after 9.0 GA, at which point we need to add 9.0 targeting pack to SBRP and update the properties introduced in dotnet/sdk#42969 to reference it.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Sep 13, 2024
@NikolaMilosavljevic NikolaMilosavljevic changed the title Enable stage 2 builds in main Enable stage 2 and other non-MSFT builds in main Sep 16, 2024
@MichaelSimons MichaelSimons moved this from Backlog to 10.0 in .NET Source Build Sep 19, 2024
@MichaelSimons MichaelSimons self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-build Improvements in source-build's own build process
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants