Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorConfig template has namespace for applicable_kinds of type_parameters naming symbol #46569

Open
daeghanelkin opened this issue Feb 5, 2025 · 1 comment
Labels
Area-WebSDK untriaged Request triage from a team member

Comments

@daeghanelkin
Copy link

Describe the bug

When using the EditorConfig template produced by dotnet new .editorconfig I noticed that the applicable_kinds for the type_parameters naming symbol is set to namespace instead of type_parameter. This leads to type parameters being missed when attempting to enforce a naming convention.

To Reproduce

With your SDK version of choice (tested with both 8 and 9) run dotnet new .editorconfig.

Within the produced .editorconfig, locate the naming symbol for type parameters (dotnet_naming_symbols.type_parameters) and inspect the value generated for applicable_kinds, it should be namespace.

Additional information

I didn't notice any existing issues/discussions surrounding having the incorrect kind, and it looks like the value has been namespace since the initial creation of the template, but please let me know if there's some extra info on if it's intentional.

I'm also familiar with templates, so I'm more than happy to make the necessary changes if this becomes a confirmed issue since it's simply replacing the offending line with:

dotnet_naming_symbols.type_parameters.applicable_kinds = type_parameter

Thanks in advance!

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-WebSDK untriaged Request triage from a team member labels Feb 5, 2025
@daeghanelkin daeghanelkin changed the title Editorconfig template has namespace for applicable_kinds of type_parameters naming symbol EditorConfig template has namespace for applicable_kinds of type_parameters naming symbol Feb 5, 2025
@daeghanelkin
Copy link
Author

Based on the CODEOWNERS file, I believe this was mislabeled as Area-WebSDK and should instead use Area-Templates .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-WebSDK untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

1 participant