Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss the handling of RunSettingsFilePath in new dotnet test experience #47636

Closed
Youssef1313 opened this issue Mar 15, 2025 · 1 comment · Fixed by #47706
Closed

Discuss the handling of RunSettingsFilePath in new dotnet test experience #47636

Youssef1313 opened this issue Mar 15, 2025 · 1 comment · Fixed by #47706
Assignees
Labels
Area-dotnet test untriaged Request triage from a team member
Milestone

Comments

@Youssef1313
Copy link
Member

Copy from microsoft/testfx#5199

Currently, the implementation of the new dotnet test experience for .NET 10 will set TESTINGPLATFORM_VSTESTBRIDGE_RUNSETTINGS_FILE environment variable.

This doesn't seem ideal. What if we considered a breaking change for the env variable name in our next major? Or even remove the env variable support completely?

Should we instead pass runsettings via --settings command line option, which is much less likely that we will want to break?

cc @mariam-abdulla


Comment by @Youssef1313

Actually there was some discussion before (microsoft/testfx#4636) where @nohwnd and @Evangelink thought that this property shouldn't be supported in MTP.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-dotnet test untriaged Request triage from a team member labels Mar 15, 2025
@Youssef1313 Youssef1313 added this to the 10.0.1xx milestone Mar 15, 2025
@Youssef1313
Copy link
Member Author

This should be handled on VSTestBridge via RunArguments. SDK shouldn't be aware of this for MTP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-dotnet test untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant