Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArPow] sourcebuild Version.Details.xml element does not support stable versions #2552

Closed
MichaelSimons opened this issue Oct 21, 2021 · 1 comment
Labels
area-build Improvements in source-build's own build process

Comments

@MichaelSimons
Copy link
Member

When stable versioning is used, the product (dependency) version number does not match the source-build intermediate package. This is because the intermediate packages are non-shipping and therefore do not get stable versioning. Source-build tarball builds require the product stable version as this gets put into the git-info and flows into the PVPs.

Version.Details.xml sample

    <Dependency Name="Microsoft.Build" Version="17.0.0" CoherentParentDependency="Microsoft.NET.Sdk">
      <Uri>https://github.com/dotnet/msbuild</Uri>
      <Sha>c9eb9dd64e9a2e8a433900a1a626d65a2bce4428</Sha>
      <SourceBuild RepoName="msbuild" ManagedOnly="true" />
    </Dependency>

Error

.nuget/packages/microsoft.dotnet.arcade.sdk/6.0.0-beta.21519.3/tools/Tools.proj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Microsoft.SourceBuild.Intermediate.msbuild with version (= 17.0.0)
@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Oct 21, 2021
@MichaelSimons
Copy link
Member Author

Closing as the recommendation is to explicitly list the SB dependency on the intermediate package.

@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-build Improvements in source-build's own build process
Projects
Status: Done
Development

No branches or pull requests

1 participant