Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .editorconfig to SBRP #3759

Closed
ellahathaway opened this issue Nov 27, 2023 · 0 comments · Fixed by dotnet/source-build-reference-packages#1204
Closed

Add .editorconfig to SBRP #3759

ellahathaway opened this issue Nov 27, 2023 · 0 comments · Fixed by dotnet/source-build-reference-packages#1204
Assignees
@MichaelSimons
Labels
area-sbrp Source build reference packages

Comments

@ellahathaway
Copy link
Member

It would be helpful to add an .editorconfig to source-build-reference-packages repo.

.editorconfigs: https://github.com/dotnet/maintenance-packages/blob/5fa252991a931aded571a63b12159de2040f6bc9/.editorconfig, https://github.com/dotnet/installer/blob/main/.editorconfig

Related MSBuild property: https://github.com/dotnet/maintenance-packages/blob/5fa252991a931aded571a63b12159de2040f6bc9/Directory.Build.props#L15
@ellahathaway ellahathaway self-assigned this Nov 27, 2023
@ellahathaway ellahathaway mentioned this issue Nov 27, 2023
Merged
@MichaelSimons MichaelSimons added area-sbrp Source build reference packages untriaged labels Nov 28, 2023
@MichaelSimons MichaelSimons moved this from Backlog to 9.0 in .NET Source Build Dec 7, 2023
@ellahathaway ellahathaway moved this from 9.0 to In Progress in .NET Source Build Dec 12, 2023
@MichaelSimons MichaelSimons mentioned this issue Jan 23, 2024
Merged
@MichaelSimons MichaelSimons moved this from In Progress to 9.0 in .NET Source Build Mar 14, 2024
@MichaelSimons MichaelSimons moved this from 9.0 to 10.0 in .NET Source Build Jul 1, 2024
@MichaelSimons MichaelSimons moved this from 10.0 to 10 Candidate in .NET Source Build Feb 6, 2025
@MichaelSimons MichaelSimons self-assigned this Mar 19, 2025
@MichaelSimons MichaelSimons moved this from 10 Candidate to In Progress in .NET Source Build Mar 19, 2025
@MichaelSimons MichaelSimons mentioned this issue Mar 19, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelSimons MichaelSimons

Labels
area-sbrp Source build reference packages
Projects
.NET Source Build
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add .editorconfig and formatted non-generated C# code MichaelSimons/source-build-reference-packages
2 participants
@MichaelSimons @ellahathaway