Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner repo builds should not double pass args #3789

Open
mmitche opened this issue Dec 13, 2023 · 3 comments
Open

Inner repo builds should not double pass args #3789

mmitche opened this issue Dec 13, 2023 · 3 comments

Comments

@mmitche
Copy link
Member

mmitche commented Dec 13, 2023

The inner repo build command is based on the outer repo build command. Basically arcade is just taking the outer build command, adding a few new args, and then launching the new command. Duplicated args end up using the second value. This leads to some problems and some general awkwardness:

  • Some args seem to ocassionally cause problems when passed twice. /bl: doesn't seem to override properly (at least in roslyn builds).
  • It can be difficult to glance at a command line and identify what is going on.

T-Shirt Size: Small (probably not critical but ideal)

@mmitche mmitche converted this from a draft issue Dec 13, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Dec 13, 2023
@MichaelSimons MichaelSimons added area-arcade Common Arcade source-build infra and removed area-build Improvements in source-build's own build process untriaged labels Dec 14, 2023
@MichaelSimons MichaelSimons moved this from Backlog to 9.0 in .NET Source Build Dec 14, 2023
@MichaelSimons MichaelSimons moved this from 9.0 to 10.0 in .NET Source Build Jul 2, 2024
@mmitche
Copy link
Member Author

mmitche commented Jan 6, 2025

Fit and finish item.

@MichaelSimons MichaelSimons moved this from 10.0 to 10 Candidate in .NET Source Build Feb 6, 2025
@MichaelSimons MichaelSimons added area-unified-build and removed area-arcade Common Arcade source-build infra labels Feb 20, 2025
@Winniexu01
Copy link
Member

This issue will be fixed in another way in the future: dotnet/arcade#15650 (comment)

@ellahathaway
Copy link
Member

Reopening this issue since it'll be completed with #4249

@ellahathaway ellahathaway reopened this Mar 20, 2025
@MichaelSimons MichaelSimons moved this from Done to Ready in .NET Unified Build Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

Successfully merging a pull request may close this issue.

4 participants