Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manifest exclusion for Mono, Shortstack verticals from join-verticals.proj #4770

Closed
akoeplinger opened this issue Nov 27, 2024 · 2 comments

Comments

@akoeplinger
Copy link
Member

This is sort of related to #4648

Because multiple non-primary verticals are producing the same assets a workaround was added to exclude Mono/Shortstack:
https://github.com/dotnet/sdk/blob/bdae92e56e504adcbba6f3d9eda3dccfd4158934/src/SourceBuild/content/eng/join-verticals.proj#L24

But this causes e.g. Mono runtime packs or NativeAOT runtime packs for maccatalyst-x64 to be excluded in the final join, even though these are only produced in one vertical.

@ViktorHofer
Copy link
Member

What remains here are the short stack manifest exclusions. Everything else got fixed. https://github.com/dotnet/sdk/blob/c257bbded0e3bf66a2a164ebb974cc7ac17bcb46/src/SourceBuild/content/eng/join-verticals.proj#L26

@jkoritzinsky
Copy link
Member

Fixed by dotnet/sdk#46568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants