Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MakeOfficialBuildId= the default for source-only non-official build setup #4855

Open
ViktorHofer opened this issue Jan 30, 2025 · 2 comments
Labels
area-build Improvements in source-build's own build process

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 30, 2025

Same issue as #4613 but for source-only builds

This needs to wait until we snap for Preview 3 to only apply to Preview 4 and later which is when we start shipping from the VMR.

@ViktorHofer ViktorHofer changed the title MakeOFficialBuildId= the default for source-only non-official build setup MakeOfficialBuildId= the default for source-only non-official build setup Jan 30, 2025
@MichaelSimons
Copy link
Member

[Triage] Some additional changes are needed as a result of making this. The source build release process would need to include the OfficialBuildId info as part of the release. Additionally when doing the final builds, there needs to be a source build CI run with the same OfficialBuildId input in order to produce the artifacts and sdks that get uploaded to blob storage. How would these builds get queued is something that needs to be flushed out.

@MichaelSimons MichaelSimons added the area-build Improvements in source-build's own build process label Jan 30, 2025
@MichaelSimons MichaelSimons moved this from Backlog to 10.0 Preview 2 in .NET Source Build Jan 30, 2025
@MichaelSimons
Copy link
Member

Stable versioning would make this UX a lot better for end users as they would not have to specify the OfficialBuildId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-build Improvements in source-build's own build process
Projects
Status: 10.0 Preview 2
Development

No branches or pull requests

2 participants