Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[source-build] Poison check should scan all shipping packages #4921

Closed
NikolaMilosavljevic opened this issue Feb 27, 2025 · 1 comment · Fixed by dotnet/sdk#47176
Closed

[source-build] Poison check should scan all shipping packages #4921

NikolaMilosavljevic opened this issue Feb 27, 2025 · 1 comment · Fixed by dotnet/sdk#47176
Assignees
@NikolaMilosavljevic
Labels
area-poison Poison leaks and the leak detection infrastructure untriaged

Comments

@NikolaMilosavljevic
Copy link
Member

It appears that NuGet packages are not being scanned for poison - the following line will not include any packages: https://github.com/dotnet/sdk/blob/50702508f006c8c0b362493bd1a8b945845b06e4/src/SourceBuild/content/eng/finish-source-only.proj#L134-L135

      <!-- Include shipping nuget packages. -->
      <PoisonFileToCheck Include="$(ArtifactsShippingPackagesDir)*.nupkg" />

This was likely caused by distributed/parallelized build refactoring that moved packages to repo sub-directories.

Tasks:

  • Fix this issue in main
  • Ensure 9.0 is correct
  • Harden the infra to prevent this regression in the future
@NikolaMilosavljevic NikolaMilosavljevic self-assigned this Feb 27, 2025
@MichaelSimons MichaelSimons moved this from Backlog to In Progress in .NET Source Build Feb 27, 2025
@NikolaMilosavljevic
Copy link
Member Author

No poison issues were found in main or 9.0.

@MichaelSimons MichaelSimons added the area-poison Poison leaks and the leak detection infrastructure label Feb 27, 2025
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Feb 27, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-poison Poison leaks and the leak detection infrastructure untriaged
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check shipping packages for poison NikolaMilosavljevic/sdk
2 participants
@MichaelSimons @NikolaMilosavljevic