Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use live built targeting packs and remove SBRP self dependency #1192

Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 5, 2025

Depends on #1189, #1190 and #1191
Fixes dotnet/source-build#4932 and dotnet/source-build#4931

  • Use the live built targeting packs by using the same hook that we use in runtime and various others repos. For netstandard2.0, manually import the build targets file that brings the references in.

  • Remove the SBRP self dependency

- Use the live built targeting packs by using the same hook that we use in runtime and various others repos. For netstandard2.0, manually import the build targets file that brings the references in.

- Remove the SBRP self dependency
@ViktorHofer ViktorHofer requested a review from a team as a code owner March 5, 2025 11:33
@MichaelSimons MichaelSimons enabled auto-merge (squash) March 5, 2025 14:46
@MichaelSimons MichaelSimons merged commit ea76780 into main Mar 5, 2025
4 checks passed
@ViktorHofer ViktorHofer deleted the UseLocalTargetingPacksAndRemoveSBRPSelfReference branch March 5, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SBRP self-reference in Version.Details.xml
3 participants