-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unified-build lite pipeline #4934
Comments
@dotnet/product-construction @dotnet/source-build |
Few quick questions:
|
Two goals:
|
OK that makes sense and adds value. Could we re-use the existing dotnet-unified-build pipeline by making it possible to set the type as a queue trigger similar to the |
That seems interesting - we'd have |
Yes, we would keep the current defaults. We have the different scopes listed here: https://github.com/dotnet/sdk/blob/b1d1a0d44487a18a0989ced4fb4c23530da3744f/src/SourceBuild/content/eng/pipelines/ci.yml#L155-L164 @mmitche @akoeplinger are you ok with the proposed change to be able to set the scope when triggering the dotnet-unified-build pipeline? |
Sounds good to me |
I really like the idea of just making the queue time parameters a bit more descriptive |
I presume we still want to maintain different set of jobs for different verification scenarios, i.e. internal vs public, CI vs PR. I do intend to add one or two jobs for internal CI verification that would build tests. Currently we only do that in public CI or public PR. |
Validation of vmr changes does not always require running all unified-build legs.
Having a
lite
pipeline could help improve throughput, and save build resources.This could also enable us to validate legs that build tests, as those are now only enabled in public CI or PR.
Some concerns
Today we run jobs that build tests in public Validation jobs only: https://github.com/dotnet/sdk/blob/d833ffb8016b3937b6c13db926fc1acbac254dd7/eng/pipelines/templates/stages/vmr-build.yml#L354-L387
To avoid duplicating jobs in main pipeline yml, perhaps we should just update that condition to include internal/lite scenario and update the comment.
Not sure if both Linux and Windows jobs for building tests would be required, or just one of them.
The text was updated successfully, but these errors were encountered: