-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SignCheck should validate files without extensions #4937
Comments
We should not check all extensionless files because not all extensionless files are signable. Rather, we should only check extensionless files that the user specifically specifies and/or are included as |
Unfortunately the build manifest won't contain the signing information any longer, and wouldn't have had it anyway unless post build signing was on. Is there a way to identify whether an extensionless file is an executable on Linux/Mac? |
Good to know. Current SignCheck infra assumes that it does, so I'll file an issue to get that logic cleaned up. Edit: Filed dotnet/arcade#15621
Yes, one option is to shell out to the command line and use "file". Another option may be to read the first two bytes of the file & check that or use some existing API |
See dotnet/arcade#15623 (comment). Closing this issue and opening a new issue for verifying MachO files instead. |
We currently skip verifying files without extensions, but we should verify them because they can technically be signed.
The text was updated successfully, but these errors were encountered: