Projects using PackAsToolShimRuntimeIdentifiers are missing assets in VMR

[wtgodbe]

Projects that list multiple rids in PackAsToolShimRuntimeIdentifiers are broken in the VMR - we have to list only 1 RID for those (the current one) in the VMR, which means they're not packing the full set of assets they should be. e.g. https://github.com/dotnet/aspnetcore/blob/e6d943297f981ae68003b215f0cee66891cdf8ae/src/Tools/Directory.Build.targets#L5-L6 and https://github.com/dotnet/sdk/blob/9c64e2f36f03e62ca82659c0e08e0b46514df2d4/src/BuiltInTools/dotnet-format/dotnet-format.csproj#L26-L27. We need to figure out a way to build these in the VMR & pack the full set of RID-specific shims in 1 package

CC @dsplaisted do you know how this functionality is supposed to work?

[dsplaisted]

do you know how this functionality is supposed to work?

We package the shims / hosts with our tools because they need to be signed. And we want the tools to be runnable from multiple architectures (or from WOW64 I assume), so we need the shims for multiple RIDs.

Is that what you were asking about?

My understanding is that the VMR builds everything for a single architecture and so creating packages that include assets from multiple architectures is difficult. So I can see how this would be problematic but don't know how the VMR build handles situations like this.

[mmitche]

The VMR has a second pass where it can take input from multiple verticals of the first pass and combine them together.

[ViktorHofer]

I just searched through dotnet/dotnet. We only have 14 tools PackAsTool packages that set PackAsToolShimRuntimeIdentifiers: https://github.com/search?q=repo%3Adotnet%2Fdotnet%20PackAsToolShimRuntimeIdentifiers&type=code

dotnet/diagnostics: 8
dotnet/runtime: 1
dotnet/command-line-api: 1
dotnet/efcore: 1
dotnet/sourcelink 1
dotnet/aspnetcore: 1
dotnet/sdk: 1

Only the repos that use the live runtime shared framework (not just nuget packages) need infra support here. We should update those repos and condition their use of live runtime shared framework artifacts on whether the project sets PackAsToolShimRuntimeIdentifiers.

Here's an example of wpf's usage of the live runtime shared framework: https://github.com/dotnet/wpf/blob/d3589ca1397f4bf697d990fc40ea54700df1159c/eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.targets#L30-L42

[ViktorHofer]

I think this means only winforms, wpf, aspnetcore and (apparently) sdk are impacted. The infra that consumes the live shared framework (see the example link above) needs to be conditioned to not use live when the project sets PackAsToolShimRuntimeIdentifiers.

And these two conditions need to get updated:

• https://github.com/dotnet/dotnet/blob/f99fb7408efb0b54f5df119e7de8b06d0f098759/src/aspnetcore/src/Tools/Directory.Build.targets#L5-L6
• https://github.com/dotnet/dotnet/blob/f99fb7408efb0b54f5df119e7de8b06d0f098759/src/sdk/src/BuiltInTools/dotnet-format/dotnet-format.csproj#L26-L27

[mmitche]

@NikolaMilosavljevic can you take a look at this one?