Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scenario-tests not uploading results to AzDO #47737

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Mar 19, 2025

This got broken in da71343 when the test execution was moved into the RepoTest target but the target which writes the AzDO variable wasn't updated

Fixes dotnet/source-build#4950

This got broken in da71343 when the test execution was moved into the RepoTest target but the target which writes the AzDO variable wasn't updated
@akoeplinger akoeplinger requested review from a team as code owners March 19, 2025 14:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/SourceBuild/content/repo-projects/scenario-tests.proj: Language not supported
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 19, 2025
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix but I wonder why BeforeTargets="Test" doesn't work. The Test target should run. IOW why does this fix the issue?

@akoeplinger
Copy link
Member Author

@ViktorHofer BeforeTargets runs after the DependsOnTargets and since that one fails this never happens.

@ViktorHofer ViktorHofer merged commit a0ebb7a into main Mar 19, 2025
41 checks passed
@ViktorHofer ViktorHofer deleted the akoeplinger-patch-1 branch March 19, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario tests aren't being published in SB stage 2 for PR builds
5 participants