Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aspnetcore is missing artifacts from getting signed via in-built signing in the VMR #4951

Closed
ViktorHofer opened this issue Mar 17, 2025 · 0 comments · Fixed by dotnet/aspnetcore#61022
Closed

aspnetcore is missing artifacts from getting signed via in-built signing in the VMR #4951

ViktorHofer opened this issue Mar 17, 2025 · 0 comments · Fixed by dotnet/aspnetcore#61022
Assignees
@wtgodbe
Labels
area-unified-build

Comments

@ViktorHofer
Copy link
Member

https://github.com/dotnet/aspnetcore/blob/e78c1a3ed28b771954596c293752faa9293fe6ee/eng/Signing.props#L19-L26

(Unix-) Assets that are getting published in Publishing.props are missing from that list. Ideally aspnetcore would do the following:

  1. Stop resetting Arcade's defaults: https://github.com/dotnet/aspnetcore/blob/e78c1a3ed28b771954596c293752faa9293fe6ee/eng/Signing.props#L5-L10
  2. Using the Artifact extension point in Signing.props so that items are in sync between Signing and Publishing.

cc @ellahathaway @jkoritzinsky @mmitche
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wtgodbe wtgodbe

Labels
area-unified-build
Projects
.NET Unified Build
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make signing less custom dotnet/aspnetcore
3 participants
@ViktorHofer @MichaelSimons @wtgodbe