Make signing less custom #61022
Merged
Make signing less custom #61022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
wtgodbe
commented
Mar 19, 2025
ViktorHofer
reviewed
Mar 19, 2025
ViktorHofer
reviewed
Mar 19, 2025
ViktorHofer
reviewed
Mar 19, 2025
eng/Signing.props
Outdated
Comment on lines
85
to
94
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.deb" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.rpm" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.tar.gz" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.exe" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.msi" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.zip" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
|
|
||
| <_InstallersToPublish Include="$(ArtifactsDir)installers\$(Configuration)\**\*.exe" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsDir)installers\$(Configuration)\**\*.msi" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> | ||
| <_InstallersToPublish Include="$(ArtifactsDir)installers\$(Configuration)\**\*.zip" UploadPathSegment="Runtime/" ChecksumPath="%(FullPath).sha512" /> |
There was a problem hiding this comment.
Consider grouping all these together into one item (with a ; as the separator per line) so that the metadata doesn't need to be defined everytime.
ViktorHofer
reviewed
Mar 19, 2025
ViktorHofer
approved these changes
Mar 19, 2025
ViktorHofer
reviewed
Mar 19, 2025
ViktorHofer
reviewed
Mar 19, 2025
| <!-- $(InstallersOutputPath), $(SymbolsOutputPath), and $(ChecksumExtensions) are not defined. Root Directory.Build.props is not imported. --> | ||
| <ItemGroup> | ||
| <!-- Prepare for _PublishInstallersAndChecksums target. --> | ||
| <_InstallersToPublish Include="$(ArtifactsPackagesDir)**\*.jar" UploadPathSegment="jar/" ChecksumPath="%(FullPath).sha512" Condition="'$(PublishAllBuildsAssetsInThisJob)' == 'true'" /> |
There was a problem hiding this comment.
This name is a bit misleading given that those also sign. That's a really small nit comment though ;)
Co-authored-by: Viktor Hofer <[email protected]>
wtgodbe
commented
Mar 19, 2025
wtgodbe
commented
Mar 19, 2025
wtgodbe
commented
Mar 19, 2025
mmitche
reviewed
Mar 19, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop resetting Arcade defaults for signing, instead use
Artifactextensibility point. Should fix dotnet/source-build#4951Test aspnetcore build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2667466&view=results
Test VMR build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2667468&view=results