Allow winforms binaries in the VMR #47745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- src/SourceBuild/content/eng/allowed-vmr-binaries.txt: Language not supported
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jkoritzinsky
approved these changes
Mar 19, 2025
ViktorHofer
approved these changes
Mar 20, 2025
mthalman
reviewed
Mar 20, 2025
| src/winforms/src/test/integration/MauiTests/lib/*.dll | ||
| src/winforms/src/test/integration/WinformsControlsTest/Resources/media.mpg | ||
| src/winforms/src/test/unit/System.Windows.Forms/bitmaps/milkmateya01.emf | ||
| src/winforms/src/test/unit/System.Windows.Forms/bitmaps/telescope_01.wmf |
There was a problem hiding this comment.
We already have src/winforms/src/System.Windows.Forms*/**/*.wmf. Should that be broadened in scope so we don't need to have this entry as well?
There was a problem hiding this comment.
Addressed in 7675163
mthalman
approved these changes
Mar 20, 2025
|
@dotnet/source-build - can I get help merging this? TIA. |
|
/backport to release/10.0.1xx-preview3 |
|
Started backporting to release/10.0.1xx-preview3: https://github.com/dotnet/sdk/actions/runs/13999549854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dotnet/source-build#4957