Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SBRP] Placeholder files shouldn't be filtered out for out-of-support TFMs #4961

Open
ViktorHofer opened this issue Mar 20, 2025 · 0 comments
Labels
area-sbrp Source build reference packages

Comments

@ViktorHofer
Copy link
Member

https://github.com/dotnet/source-build-reference-packages/blob/b99d40df247e865fb0a9de15bdcfdfa7f550a55e/src/packageSourceGenerator/PackageSourceGeneratorTask/GetPackageItems.cs#L114

Placeholder files (_._) are important to keep, even if the TFM folder it is placed in is already out-of-support and not interesting for SBRP. Example:

<Project>

  <PropertyGroup>
    <TargetFrameworks>netstandard2.0;netcoreapp2.0</TargetFrameworks>
  </PropertyGroup>

  ...

</Project>

In that example, the netcoreapp2.0 placeholder file gets filtered out and the netstandard2.0 assembly is picked by the consumer. That's incorrect in cases where the assembly got moved inbox or where the implementation differs significantly, i.e. for System.Runtime.CompilerServices.Unsafe.

@MichaelSimons MichaelSimons added area-sbrp Source build reference packages and removed untriaged labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-sbrp Source build reference packages
Projects
Status: Backlog
Development

No branches or pull requests

2 participants