Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are build failures ignored during indexing? #67

Open
Gnbrkm41 opened this issue Aug 21, 2020 · 2 comments
Open

Why are build failures ignored during indexing? #67

Gnbrkm41 opened this issue Aug 21, 2020 · 2 comments

Comments

@Gnbrkm41
Copy link

<Exec Command="cmd /c &quot;$(PrepareCommand)&quot;" WorkingDirectory="%(ClonedRepository.LocalPath)" ContinueOnError="true" IgnoreStandardErrorWarningFormat="true" LogStandardErrorAsError="false" IgnoreExitCode="true"/>

Currently it seems like build failures for the the repositories to be indexed are ignored. It's weird those are ignored and the build succeeds like nothing happened; this leads to the server running fine but not actually showing the results for the failed repository.

I suppose this is the reason for issues like #60?

@tannergooding
Copy link
Member

It might be nice if build failures logged an issue against the repo so they are known when they happen.

I would guess they are ignored so a single failure doesn't bring down all of source.dot.net

@alexperovich
Copy link
Member

Yea, they are ignored because its... rare that all the product repos all build successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants