Skip to content

Conversation

@MiYanni
Copy link
Member

@MiYanni MiYanni commented Oct 16, 2025

Fixes: #9429

Summary

In the official pipeline, -integrationTest was specified. However, the build would run both integration tests and unit tests. It seems the easiest way was to specify /p:Test=false on these builds, which disabled running tests altogether.

Build Run

@MiYanni MiYanni requested a review from a team as a code owner October 16, 2025 21:55
Copy link
Member

@joeloff joeloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assumption being that tests ran during PR?

@MiYanni
Copy link
Member Author

MiYanni commented Oct 16, 2025

@joeloff Good call. I actually messed up where it looks like Windows is only run in official builds, while Linux and Mac are only ran for internal PR builds. Let me undo the changes for Linux/Mac. I don't know why it is designed that way, but it is what it is.

Edit: Oh wait. No, Windows is always ran and Linux/Mac are PR only. Okay, I gotta condition it then for Windows. I'll do that too.

@MiYanni
Copy link
Member Author

MiYanni commented Oct 16, 2025

Build succeeded. Merging.

@MiYanni MiYanni merged commit f52119e into dotnet:main Oct 16, 2025
9 checks passed
@MiYanni MiYanni deleted the NoTestsInOfficial branch October 16, 2025 23:56
@marcpopMSFT
Copy link
Member

@backport to release/8.0.1xx

@marcpopMSFT
Copy link
Member

We're still showing up on the dashboard I think from the servicing branches it looks like. requested copilot backport as the backport bot appears broken.

Copilot AI added a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable test execution on CI builds

3 participants