Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sizing issues of the IFrame containing the interactive editor #1198

Open
ocallesp opened this issue May 23, 2024 · 9 comments
Open

Sizing issues of the IFrame containing the interactive editor #1198

ocallesp opened this issue May 23, 2024 · 9 comments

Comments

@ocallesp
Copy link
Contributor

ocallesp commented May 23, 2024

image

This is needed in order to improve the UI.

In production it looks seamless
image

however with the new version we can see some unnecessary overflow
image

@ocallesp ocallesp self-assigned this May 23, 2024
@AbhitejJohn
Copy link
Contributor

Additional context: this is specific to the marketing page.

@ocallesp
Copy link
Contributor Author

@jonsequitur
Copy link
Contributor

The editor can be found here: https://dotnet.microsoft.com/en-us/languages

@ocallesp
Copy link
Contributor Author

ocallesp commented Jun 4, 2024

The fix should go in the host

@ocallesp ocallesp closed this as completed Jun 4, 2024
@jonsequitur jonsequitur reopened this Jun 4, 2024
@jonsequitur
Copy link
Contributor

The element that needs to be sized is here:
image

It should be sized using the Monaco API, which is exposed by trydotnet.js.

@danzhu54
Copy link

@jonsequitur can you point me to the Monaco API for sizing?

@jonsequitur
Copy link
Contributor

https://microsoft.github.io/monaco-editor/typedoc/interfaces/editor.IEditor.html#layout.layout-1

@danzhu54
Copy link

When does the editor set the size by default?
It seems to be called twice: once when it initializes and then again when I set the size with setSize
image

Is it possible for me to pass in my size preferences to the editor via createSessionWithProjectAndOpenDocument?

@ocallesp
Copy link
Contributor Author

@danzhu54 you cannot pass the size of the editor via createSessionWithProjectAndOpenDocument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants