Skip to content

Commit 3773447

Browse files
[automated] Merge branch 'main' => 'prerelease' (#8051)
2 parents dbac654 + e040176 commit 3773447

File tree

7 files changed

+59
-20
lines changed

7 files changed

+59
-20
lines changed

.github/policies/resourceManagement.yml

+23
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,29 @@ configuration:
1010

1111
eventResponderTasks:
1212

13+
- description: Auto-approve/merge automated merge PRs
14+
triggerOnOwnActions: false
15+
if:
16+
- payloadType: Pull_Request
17+
- isPullRequest
18+
- isActivitySender:
19+
user: github-actions[bot]
20+
issueAuthor: False
21+
- or:
22+
- titleContains:
23+
pattern: "[automated] Merge branch"
24+
isRegex: False
25+
- titleContains:
26+
pattern: "[automated] Update main version"
27+
isRegex: False
28+
- isAction:
29+
action: Opened
30+
then:
31+
- approvePullRequest:
32+
comment: Auto-approve
33+
- enableAutoMerge:
34+
mergeMethod: merge
35+
1336
- description: Add "untriaged" label to issues when opened
1437
triggerOnOwnActions: false
1538
if:

.github/workflows/branch-snap.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,5 @@ jobs:
3131
with:
3232
token: ${{ secrets.GITHUB_TOKEN }}
3333
commit-message: Update main version
34-
title: 'Update main version'
34+
title: '[automated] Update main version'
3535
branch: merge/update-main-version

CHANGELOG.md

+24
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,30 @@
33
- Diagnostics related feature requests and improvements [#5951](https://github.com/dotnet/vscode-csharp/issues/5951)
44
- Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)
55

6+
# 2.69.x
7+
* Bump razor to 9.0.0-preview.25156.2 (PR: [#8047](https://github.com/dotnet/vscode-csharp/pull/8047))
8+
* Enable FUSE by default
9+
* Improve solution load performance (#11591) (PR: [#11591](https://github.com/dotnet/razor/pull/11591))
10+
* Make logging fall into the pit of success (#11581) (PR: [#11581](https://github.com/dotnet/razor/pull/11581))
11+
* Bump xamlTools to 17.14.35904.287 (PR: [#8042](https://github.com/dotnet/vscode-csharp/pull/8042))
12+
* Update Roslyn to 4.14.0-3.25156.1 (PR: [#8049](https://github.com/dotnet/vscode-csharp/pull/8049))
13+
* Don't use an implicit-object if the lang version doesn't support it (PR: [#77437](https://github.com/dotnet/roslyn/pull/77437))
14+
* Fix issue where we were changing semantics when converting to a collection expr. (PR: [#77417](https://github.com/dotnet/roslyn/pull/77417))
15+
* Detect and emit more idiomatic null check patterns (PR: [#77412](https://github.com/dotnet/roslyn/pull/77412))
16+
* Partial events and constructors: IDE (PR: [#77337](https://github.com/dotnet/roslyn/pull/77337))
17+
* Simplify keyword recommenders. (PR: [#77396](https://github.com/dotnet/roslyn/pull/77396))
18+
* Remove async/await (PR: [#77397](https://github.com/dotnet/roslyn/pull/77397))
19+
* Preserve encoding during DocumentState updates (PR: [#77354](https://github.com/dotnet/roslyn/pull/77354))
20+
* Don't realize the SourceText in SyntaxTree.OverlapsHiddenPosition if not needed (PR: [#77334](https://github.com/dotnet/roslyn/pull/77334))
21+
* Handle ModuleCancellationTokenExpression in AbstractFlow visitor (PR: [#77310](https://github.com/dotnet/roslyn/pull/77310))
22+
* PERF: Reduce the number of nodes walked during import completion commit. (PR: [#77305](https://github.com/dotnet/roslyn/pull/77305))
23+
* Allow expression body refactorings on non empty selections (PR: [#76969](https://github.com/dotnet/roslyn/pull/76969))
24+
* Partial events and constructors: public API (PR: [#77202](https://github.com/dotnet/roslyn/pull/77202))
25+
* Refresh diagnostics when fading options change (PR: [#77322](https://github.com/dotnet/roslyn/pull/77322))
26+
* Reduce allocations during completion in FilterToVisibleAndBrowsableSymbols (PR: [#77315](https://github.com/dotnet/roslyn/pull/77315))
27+
* Change override completion to select text after updating the buffer. (PR: [#76983](https://github.com/dotnet/roslyn/pull/76983))
28+
* Fix false positive 'Unnecessary assignment of a value' (PR: [#77297](https://github.com/dotnet/roslyn/pull/77297))
29+
630
# 2.68.x
731
* Update Razor to 9.0.0-preview.25125.9 (PR: [#8027](https://github.com/dotnet/vscode-csharp/pull/8027))
832
* Don't send invalid ranges for diagnostics if they do not map (#11555) (PR: [#11555](https://github.com/dotnet/razor/pull/11555))

package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@
3737
}
3838
},
3939
"defaults": {
40-
"roslyn": "4.14.0-2.25120.5",
40+
"roslyn": "4.14.0-3.25156.1",
4141
"omniSharp": "1.39.12",
42-
"razor": "9.0.0-preview.25125.9",
42+
"razor": "9.0.0-preview.25156.2",
4343
"razorOmnisharp": "7.0.0-preview.23363.1",
44-
"xamlTools": "17.14.35828.13"
44+
"xamlTools": "17.14.35904.287"
4545
},
4646
"main": "./dist/extension",
4747
"l10n": "./l10n",
@@ -1519,7 +1519,7 @@
15191519
"razor.languageServer.forceRuntimeCodeGeneration": {
15201520
"type": "boolean",
15211521
"scope": "machine-overridable",
1522-
"default": null,
1522+
"default": true,
15231523
"description": "%configuration.razor.languageServer.forceRuntimeCodeGeneration%",
15241524
"order": 90
15251525
},

src/razor/src/razorLanguageServerOptionsResolver.ts

+1-11
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,7 @@ export function resolveRazorLanguageServerOptions(
2323
const usingOmniSharp =
2424
!getCSharpDevKit() && vscodeApi.workspace.getConfiguration().get<boolean>('dotnet.server.useOmnisharp');
2525

26-
const hotReload = vscodeApi.workspace.getConfiguration('csharp.experimental.debug').get<boolean>('hotReload');
27-
28-
let forceRuntimeCodeGeneration = serverConfig.get<boolean | null>('forceRuntimeCodeGeneration');
29-
30-
if (forceRuntimeCodeGeneration === null && hotReload) {
31-
logger.logMessage(
32-
'Hot Reload is enabled so treating "razor.languageServer.forceRuntimeCodeGeneration" as true. To override this set "razor.languageServer.forceRuntimeCodeGeneration" to true or false.'
33-
);
34-
35-
forceRuntimeCodeGeneration = hotReload;
36-
}
26+
const forceRuntimeCodeGeneration = serverConfig.get<boolean>('forceRuntimeCodeGeneration');
3727

3828
const suppressErrorToasts = serverConfig.get<boolean>('suppressLspErrorToasts');
3929
const useNewFormattingEngine = serverConfig.get<boolean>('useNewFormattingEngine');

test/lsptoolshost/integrationTests/codeactions.integration.test.ts

+5-3
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,12 @@ describe(`Code Actions Tests`, () => {
7979
test('Add accessibility modifiers applied', async () => {
8080
const actions = await getCodeActions(new vscode.Range(6, 16, 6, 19), 10);
8181

82-
expect(actions[0].title).toBe('Add accessibility modifiers');
83-
expect(actions[0].edit).toBeDefined();
82+
const action = actions.find((a) => a.title === 'Add accessibility modifiers');
8483

85-
await vscode.workspace.applyEdit(actions[0].edit!);
84+
expect(action).toBeDefined();
85+
expect(action!.edit).toBeDefined();
86+
87+
await vscode.workspace.applyEdit(action!.edit!);
8688

8789
await expectText(vscode.window.activeTextEditor!.document, [
8890
'using System;',

version.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
3-
"version": "2.68",
3+
"version": "2.69",
44
"publicReleaseRefSpec": [
55
"^refs/heads/release$",
66
"^refs/heads/prerelease$",

0 commit comments

Comments
 (0)