Skip to content

Commit efa46c2

Browse files
committed
Merge branch 'copilot/fix-2297' of https://github.com/dotnet/vscode-dotnet-runtime into copilot/fix-2297
2 parents 7897dce + d4c6683 commit efa46c2

27 files changed

+8096
-9780
lines changed

1es-azure-pipeline.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@ extends:
9494
- template: pipeline-templates/lint.yaml@self
9595
parameters:
9696
pool:
97-
name: Azure Pipelines
98-
image: macOS-latest
99-
os: macOS
97+
name: NetCore1ESPool-Internal
98+
image: 1es-windows-2022
99+
os: windows
100100
useOneEngineeringPool: true
101101
- template: pipeline-templates/package-vsix.yaml@self
102102
parameters:

1pr-azure-pipeline.yml

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,21 @@ variables:
2020
value: true
2121

2222
# The public PR pool schema is different from the 1ES one. We use 'vmImage' which is a default azure pipeline schema. 'os' and 'name' have nothing to do with image selection here.
23-
# 1ES uses 'image' but defining an image this way using our public pools duseOneEngineeringPool not work as they aren't configured this way.
23+
# 1ES uses 'image' but defining an image this way using our public pools useOneEngineeringPool not work as they aren't configured this way.
2424
# We can later add the flag 'useOneEngineeringPool' or one engineering system: false or true in all tasks to determine if we use vmImage or a 1es pool object.
2525
parameters:
2626
- name: pools
2727
type: object
2828
default:
2929
- name: NetCore-Public
30-
vmImage: windows-latest
30+
demands: ImageOverride -equals 1es-windows-2022-open
3131
os: windows
3232
emoji: 🪟
3333
- name: NetCore-Public
34-
vmImage: ubuntu-latest
34+
demands: ImageOverride -equals 1es-ubuntu-2004-open
3535
os: linux
3636
emoji: 🐧
37-
- name: NetCore-Public
37+
- name: Azure Pipelines
3838
vmImage: macOS-latest
3939
os: macOS
4040
emoji: 🍎
@@ -46,7 +46,11 @@ stages:
4646
- template: pipeline-templates/build-test.yaml
4747
parameters:
4848
pool:
49-
vmImage: ${{ image.vmImage }}
49+
name: ${{ image.name }}
50+
${{ if image.demands }}:
51+
demands: ${{ image.demands }}
52+
${{ if image.vmImage }}:
53+
vmImage: ${{ image.vmImage }}
5054
os: ${{ image.os }}
5155
emoji: ${{ image.emoji }}
5256
useOneEngineeringPool: false
@@ -59,13 +63,15 @@ stages:
5963
- template: pipeline-templates/lint.yaml
6064
parameters:
6165
pool:
62-
vmImage: macOS-latest
63-
os: macOS
66+
name: NetCore-Public
67+
demands: ImageOverride -equals 1es-windows-2022-open
68+
os: windows
6469
useOneEngineeringPool: false
6570
- template: pipeline-templates/package-vsix.yaml
6671
parameters:
6772
pool:
68-
vmImage: windows-latest
73+
name: NetCore-Public
74+
demands: ImageOverride -equals 1es-windows-2022-open
6975
os: windows
7076
useOneEngineeringPool: false
7177
SignType: Test

0 commit comments

Comments
 (0)