Access web driver's properties only in try-catch (#1267)

ilonatommy · web-flow · commit 9a7efc69bd8a · 2024-09-14T07:45:47.000+02:00
* Fix.
diff --git a/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs b/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs
@@ -105,11 +105,11 @@ protected override async Task<ExitCode> InvokeInternal(ILogger logger)
 
             // close all tabs before quit is a workaround for broken Selenium - GeckoDriver communication in Firefox
             // https://github.com/dotnet/runtime/issues/101617
-            logger.LogInformation($"Closing {driver.WindowHandles.Count} browser tabs before setting the main tab to config page and quitting.");
             var cts = new CancellationTokenSource();
             cts.CancelAfter(10000);
             try
             {
+                logger.LogInformation($"Closing {driver.WindowHandles.Count} browser tabs before setting the main tab to config page and quitting.");
                 while (driver.WindowHandles.Count > 1 && driverService.IsRunning)
                 {
                     if (cts.IsCancellationRequested)

Original file line number	Diff line number	Diff line change
`@@ -105,11 +105,11 @@ protected override async Task<ExitCode> InvokeInternal(ILogger logger)`
`105`	`105`
`106`	`106`	`// close all tabs before quit is a workaround for broken Selenium - GeckoDriver communication in Firefox`
`107`	`107`	`// https://github.com/dotnet/runtime/issues/101617`
`108`		`- logger.LogInformation($"Closing {driver.WindowHandles.Count} browser tabs before setting the main tab to config page and quitting.");`
`109`	`108`	`var cts = new CancellationTokenSource();`
`110`	`109`	`cts.CancelAfter(10000);`
`111`	`110`	`try`
`112`	`111`	`{`
	`112`	`+ logger.LogInformation($"Closing {driver.WindowHandles.Count} browser tabs before setting the main tab to config page and quitting.");`
`113`	`113`	`while (driver.WindowHandles.Count > 1 && driverService.IsRunning)`
`114`	`114`	`{`
`115`	`115`	`if (cts.IsCancellationRequested)`