Skip to content

Access web driver's properties only in try-catch #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Access web driver's properties only in try-catch #1267

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3fd38d
Fix.
ilonatommy Sep 13, 2024
3310998
Revert whitespace change.
ilonatommy Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@ protected override async Task<ExitCode> InvokeInternal(ILogger logger)

// close all tabs before quit is a workaround for broken Selenium - GeckoDriver communication in Firefox
// https://github.com/dotnet/runtime/issues/101617
logger.LogInformation($"Closing {driver.WindowHandles.Count} browser tabs before setting the main tab to config page and quitting.");
var cts = new CancellationTokenSource();
cts.CancelAfter(10000);
try
{
logger.LogInformation($"Closing {driver.WindowHandles.Count} browser tabs before setting the main tab to config page and quitting.");
while (driver.WindowHandles.Count > 1 && driverService.IsRunning)
{
if (cts.IsCancellationRequested)
Expand Down Expand Up @@ -265,7 +265,7 @@ protected override async Task<ExitCode> InvokeInternal(ILogger logger)
if (Arguments.NoQuit)
options.LeaveBrowserRunning = true;

logger.LogInformation($"Starting {driverName} with args: {string.Join(' ', options.Arguments)}");
logger.LogInformation($"Starting {driverName} with args: {string.Join(' ', options.Arguments)}");

// We want to explicitly specify a timeout here. This is for for the
// driver commands, like getLog. The default is 60s, which ends up
Expand Down