Added some validation tests

Author: JaBistDuNarrisch

src/Migrator.Tests/Providers/Generic/Generic_AddIndexTestsBase.cs

@@ -22,6 +22,64 @@ public void AddIndex_TableDoesNotExist()
         Assert.Throws<MigrationException>(() => Provider.AddIndex("NotExistingIndex", "NotExistingTable", "column"));
     }
 
+    [Test]
+    public void AddIndex_AddAlreadyExistingIndex_Throws()
+    {
+        // Arrange
+        const string tableName = "TestTable";
+        const string columnName = "TestColumn";
+        const string indexName = "TestIndexName";
+
+        Provider.AddTable(tableName, new Column(columnName, DbType.Int32));
+        Provider.AddIndex(tableName, new Index { Name = indexName, KeyColumns = [columnName] });
+
+        // Act/Assert
+        // Add already existing index
+        Assert.Throws<MigrationException>(() => Provider.AddIndex(tableName, new Index { Name = indexName, KeyColumns = [columnName] }));
+    }
+
+    [Test]
+    public void AddIndex_IncludeColumnsContainsColumnThatExistInKeyColumns_Throws()
+    {
+        // Arrange
+        const string tableName = "TestTable";
+        const string columnName1 = "TestColumn1";
+        const string indexName = "TestIndexName";
+
+        Provider.AddTable(tableName, new Column(columnName1, DbType.Int32));
+
+        Assert.Throws<MigrationException>(() => Provider.AddIndex(tableName,
+            new Index
+            {
+                Name = indexName,
+                KeyColumns = [columnName1],
+                IncludeColumns = [columnName1]
+            }));
+    }
+
+    [Test]
+    public void AddIndex_ColumnNameUsedInFilterItemDoesNotExistInKeyColumns_Throws()
+    {
+        // Arrange
+        const string tableName = "TestTable";
+        const string columnName1 = "TestColumn1";
+        const string columnName2 = "TestColumn2";
+        const string indexName = "TestIndexName";
+
+        Provider.AddTable(tableName,
+            new Column(columnName1, DbType.Int32),
+            new Column(columnName2, DbType.Int32)
+        );
+
+        Assert.Throws<MigrationException>(() => Provider.AddIndex(tableName,
+            new Index
+            {
+                Name = indexName,
+                KeyColumns = [columnName1],
+                FilterItems = [new FilterItem { Filter = FilterType.GreaterThan, ColumnName = columnName2, Value = 12 }]
+            }));
+    }
+
     [Test]
     public void AddIndex_UsingIndexInstanceOverload_NonUnique_ShouldBeReadable()
     {
@@ -30,7 +88,7 @@ public void AddIndex_UsingIndexInstanceOverload_NonUnique_ShouldBeReadable()
         const string columnName = "TestColumn";
         const string indexName = "TestIndexName";
 
-        Provider.AddTable(tableName, new Column(columnName, System.Data.DbType.Int32));
+        Provider.AddTable(tableName, new Column(columnName, DbType.Int32));
 
         // Act
         Provider.AddIndex(tableName, new Index { Name = indexName, KeyColumns = [columnName] });

src/Migrator/Providers/TransformationProvider.cs

@@ -2199,17 +2199,17 @@ protected void ValidateIndex(string tableName, Index index)
 
         foreach (var keyColumn in index.KeyColumns)
         {
-            if (!columns.Any(x => x.Name.Equals(keyColumn, StringComparison.OrdinalIgnoreCase)))
+            if (!index.KeyColumns.All(x => columns.Any(y => y.Name.Equals(x, StringComparison.OrdinalIgnoreCase))))
             {
                 throw new MigrationException($"Column '{keyColumn}' does not exist.");
             }
         }
 
         if (hasFilterItems)
         {
-            if (!index.KeyColumns.Any(x => index.FilterItems.Any(y => x.Equals(y.ColumnName, StringComparison.OrdinalIgnoreCase))))
+            if (!index.FilterItems.All(x => index.KeyColumns.Any(y => x.ColumnName.Equals(y, StringComparison.OrdinalIgnoreCase))))
             {
-                throw new MigrationException($"All columns in the {index.FilterItems} should exist in the {index.KeyColumns}.");
+                throw new MigrationException($"All columns in the {nameof(index.FilterItems)} should exist in the {nameof(index.KeyColumns)}.");
             }
         }