-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal Expo 52 app crashes when using form sheet modals #2401
Comments
Guessing that this is related to the timers bug which will be fixed when this pr ships: facebook/react-native#47496 |
im rather inclined to believe this is an expo issue. try reproducing without rntp. |
I tried and wasn't able to, the only thing to start causing it was adding rntp. I was thinking it might have something to do with the headless js task that rntp creates? So I was thinking of trying to repro today with a non-rntp headless task, if that's even possible on expo. |
I thought this only affected the new architecture, which I have turned off. |
u can register a headless task via AppRegistry.registerHeadlessTask. see https://reactnative.dev/docs/headless-js-android |
I tried using |
opened an issue here, maybe someone there can help me: software-mansion/react-native-screens#2507 |
Updated the repro repo to react-native 0.76.2, it didn't help |
I also just attempted to switch to the new architecture (and apply the pending RNTP patches for it), but it also didn't help. I get the exact same crash in the exact same way. Here are the new-arch updates I applied: doughsay/expo-test-app@main...new-arch |
i happen to use expo 52, react-native-screens via react navigation. RNTP is stable under either the new or old arch currently. though i dont use the expo modal, I use paper's modal/portal and its been fine. i doubt this is the issue since its screen related, but i dont see an android folder with the provided repo. i dont think ppl typically use the expo managed/plugin route with this lib, bc nobody wrote one. id recommend u installing expo following this, onto the example app #2395, upgrading to 0.76.2, then try the same thing in prod. |
Thanks, I'll see about doing that tomorrow. Which version of react-native-screens are you on? I was wondering if it's something related to the freshly released 4.0.0. but even still, if you're not using their modals I guess you still might not see any problems... |
This was confirmed to be a react-native-screens issue, and they have a fix in progress that I've confirmed fixes the crash. So we can close this issue now, and you can follow software-mansion/react-native-screens#2507 for when the actual fix lands. |
Describe the Bug
In a minimal expo 52 app with new arch disabled, having a set-up track player causes a crash when attempting to open a form sheet modal, but only after first closing the app once.
Steps To Reproduce
I have provided a minimal reproducing case that should demonstrate the issue. I've also recorded a short video showing the issue:
rntp-crash.webm
Steps:
This only happens when track player has been set up.
Code To Reproduce
Minimal expo repro app here: https://github.com/doughsay/expo-test-app
Replicable on Example App?
Can you replicate this bug in the React Native Track Player Example App?
N/A / example app doesn't use expo
Environment Info:
Paste the exact
react-native-track-player
version you are using:[email protected]
Real device? Or simulator?: both
What OS are you running?: linux
How I can Help
What can you do to help resolve this?
If this is a bug in react-native-screens or expo, I can help by opening issues with those repos as well; but since it only happens with RNTP setup, I figured I'd ask here first for some guidance.
Have you investigated the underlying JS or Swift/Android code causing this bug?
No, I don't really know where to start.
Can you create a Pull Request with a fix?
I don't know what the problem is yet.
The text was updated successfully, but these errors were encountered: