[Bug] CoinbaseAccount ID is not always a GUID

Author: dougdellolio

CoinbasePro.Specs/JsonFixtures/Services/CoinbaseAccounts/AllCoinbaseResponseFixture.cs

@@ -46,7 +46,7 @@ public static string Create()
         ""primary"": true,
         ""active"": true
     },
-     {
+    {
         ""id"": ""2a11354e-f133-5771-8a37-622be9b239db"",
         ""name"": ""EUR Wallet"",
         ""balance"": ""0.00"",
@@ -64,6 +64,18 @@ public static string Create()
             ""account_address"": ""9th Floor, 107 Cheapside, London, EC2V 6DN, United Kingdom"",
             ""reference"": ""CBAEUXOVFXOXYX""
         }
+    },
+    {
+        ""id"": ""LINK"",
+        ""name"": ""LINK Wallet"",
+        ""balance"": ""0.00"",
+        ""currency"": ""LINK"",
+        ""type"": ""wallet"",
+        ""primary"": false,
+        ""active"": true,
+        ""available_on_consumer"": true,
+        ""hold_balance"": ""0.00"",
+        ""hold_currency"": ""USD""
     }
 ]";
 

CoinbasePro.Specs/Services/CoinbaseAccounts/CoinbaseAccountsServiceSpecs.cs

@@ -32,11 +32,11 @@ class when_getting_all_coinbase_accounts
                 result = Subject.GetAllAccountsAsync().Result;
 
             It should_have_correct_count = () =>
-                result.Count().ShouldEqual(4);
+                result.Count().ShouldEqual(5);
 
             It should_have_correct_ETH_account_information = () =>
             {
-                result.First().Id.ShouldEqual(new Guid("fc3a8a57-7142-542d-8436-95a3d82e1622"));
+                result.First().Id.ShouldEqual("fc3a8a57-7142-542d-8436-95a3d82e1622");
                 result.First().Name.ShouldEqual("ETH Wallet");
                 result.First().Balance.ShouldEqual(0.00000000M);
                 result.First().Currency.ShouldEqual(Currency.ETH);
@@ -49,7 +49,7 @@ class when_getting_all_coinbase_accounts
             {
                 var usAccount = result.Skip(1).First();
 
-                usAccount.Id.ShouldEqual(new Guid("2ae3354e-f1c3-5771-8a37-6228e9d239db"));
+                usAccount.Id.ShouldEqual("2ae3354e-f1c3-5771-8a37-6228e9d239db");
                 usAccount.Name.ShouldEqual("USD Wallet");
                 usAccount.Balance.ShouldEqual(0.00M);
                 usAccount.CoinbaseAccountType.ShouldEqual(CoinbaseAccountType.Fiat);
@@ -71,7 +71,7 @@ class when_getting_all_coinbase_accounts
             {
                 var btcAccount = result.Skip(2).First();
 
-                btcAccount.Id.ShouldEqual(new Guid("1bfad868-5223-5d3c-8a22-b5ed371e55cb"));
+                btcAccount.Id.ShouldEqual("1bfad868-5223-5d3c-8a22-b5ed371e55cb");
                 btcAccount.Name.ShouldEqual("BTC Wallet");
                 btcAccount.Balance.ShouldEqual(0.00000000M);
                 btcAccount.Currency.ShouldEqual(Currency.BTC);
@@ -82,9 +82,9 @@ class when_getting_all_coinbase_accounts
 
             It should_have_correct_EU_account_information = () =>
             {
-                var euAccount = result.Last();
+                var euAccount = result.Skip(3).First();
 
-                euAccount.Id.ShouldEqual(new Guid("2a11354e-f133-5771-8a37-622be9b239db"));
+                euAccount.Id.ShouldEqual("2a11354e-f133-5771-8a37-622be9b239db");
                 euAccount.Name.ShouldEqual("EUR Wallet");
                 euAccount.Balance.ShouldEqual(0.00M);
                 euAccount.CoinbaseAccountType.ShouldEqual(CoinbaseAccountType.Fiat);
@@ -100,6 +100,18 @@ class when_getting_all_coinbase_accounts
                     "9th Floor, 107 Cheapside, London, EC2V 6DN, United Kingdom");
                 euAccount.SepaDepositInformation.Reference.ShouldEqual("CBAEUXOVFXOXYX");
             };
+
+            It should_have_correct_LINK_account_information = () =>
+            {
+                var linkAccount = result.Last();
+
+                linkAccount.Id.ShouldEqual("LINK");
+                linkAccount.Name.ShouldEqual("LINK Wallet");
+                linkAccount.Balance.ShouldEqual(0.00M);
+                linkAccount.CoinbaseAccountType.ShouldEqual(CoinbaseAccountType.Wallet);
+                linkAccount.Primary.ShouldBeFalse();
+                linkAccount.Active.ShouldBeTrue();
+            };
         }
     }
 }

CoinbasePro/Services/CoinbaseAccounts/Models/CoinbaseAccount.cs

@@ -9,7 +9,7 @@ namespace CoinbasePro.Services.CoinbaseAccounts.Models
 {
     public class CoinbaseAccount
     {
-        public Guid Id { get; set; }
+        public string Id { get; set; }
 
         public string Name { get; set; }