Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published package contains more than it should? #293

Open
9swampy opened this issue Apr 8, 2024 · 0 comments
Open

Published package contains more than it should? #293

9swampy opened this issue Apr 8, 2024 · 0 comments

Comments

@9swampy
Copy link

9swampy commented Apr 8, 2024

I've another PR to add data-action support that I've scope published pending the PR review. While working out how to publish an npm package I noted;

  1. More than I think you intend is being included in the publish package? Look at the (beta)Code tab on the package page.
  2. There's no index.d.ts.

On my repo you'll find a ScopedPackage branch that adds a GitHub action publish workflow that addresses each of the above.

Tbh I'm not certain if best practice is to include the type file or to prefer @types dev dependency, but for the scoped package the existing @types package doesn't work, so I had to include it, happy to remove; but take a look and if there's a PR you'd consider merging let me know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant