Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/audio_processing/vad porting #1

Open
leslie-wang opened this issue Aug 13, 2017 · 1 comment
Open

modules/audio_processing/vad porting #1

leslie-wang opened this issue Aug 13, 2017 · 1 comment
Labels
enhancement

Comments

@leslie-wang
Copy link

Thanks for the good project!

I'm new to VAD. Seems like this folder modules/audio_processing/vad also includes some vad related codes. is it? if yes, are you planning to port that part too?

Also wonder to know if you want to write some python binding examples or not. People can easily manipulate this library. :-)
@dpirch
Copy link
Owner

dpirch commented Aug 13, 2017

I haven't looked into modules/audio_processing/vad much, but it might be useful. Apparently it combines the VAD engine with another detector (PitchBasedVad) for better results.

I'm not planning to write python bindings at the moment (not using Python much). But there is also https://github.com/wiseman/py-webrtcvad which is a python package that wraps the same WebRTC VAD code.

dpirch pushed a commit that referenced this issue May 1, 2018
@oprypin @dpirch
Reland of Enable cpplint and fix cpplint errors in webrtc/*audio (pat…
2f30372 
…chset #1 id:1 of https://codereview.webrtc.org/2739143002/ )

Reason for revert:
Can reland it if backwards compatible API is kept.

Original issue's description:
> Revert of Enable cpplint and fix cpplint errors in webrtc/*audio (patchset #4 id:180001 of https://codereview.webrtc.org/2683033004/ )
>
> Reason for revert:
> The API change in audio/utility/audio_frame_operations.h caused breakage. Need to keep backward-compatible API.
>
> Original issue's description:
> > Enable cpplint and fix cpplint errors in webrtc/*audio
> >
> > Change usage accordingly throughout the codebase
> >
> > BUG=webrtc:5268
> >
> > TESTED=Fixed issues reported by:
> > find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py
> >
> > Review-Url: https://codereview.webrtc.org/2683033004
> > Cr-Commit-Position: refs/heads/master@{#17133}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/aebe55ca6c2f725c81031722badb297a2fb1d331
>
> [email protected],[email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5268
>
> Review-Url: https://codereview.webrtc.org/2739143002
> Cr-Commit-Position: refs/heads/master@{#17138}
> Committed: https://chromium.googlesource.com/external/webrtc/+/e47c1d3ca172e5ea84e59c1e88dbe25664664e54

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=webrtc:5268

Review-Url: https://codereview.webrtc.org/2739073003
Cr-Commit-Position: refs/heads/master@{#17144}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leslie-wang @dpirch