Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dprint installed locally with yarn #45

Open
MariaSolOs opened this issue Oct 17, 2022 · 3 comments
Open

Support for dprint installed locally with yarn #45

MariaSolOs opened this issue Oct 17, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@MariaSolOs
Copy link

Currently there seems to be the workaround of "dprint.path" to indicate the path inside local node_modules. But given that modern Yarn doesn't have a node_modules folder, how could one fix this?

For reference, this page mentions how the editor SDK hooks up with Prettier. It would be great to have something like this with dprint :)

@dsherret
Copy link
Member

I wonder if the extension should check for a package.json and if there's an entry in there for dprint and no node_modules folder, then it will check yarn's cache for a dprint package that matches the version requirement.

I don't understand the documentation on that page unfortunately.

@dsherret dsherret added the enhancement New feature or request label Nov 27, 2022
@dsherret
Copy link
Member

dsherret commented Nov 27, 2022

Actually, maybe #38 would solve this? Or maybe the extension could try running yarn bin dprint to figure out the path.

https://classic.yarnpkg.com/lang/en/docs/cli/bin/

@MariaSolOs
Copy link
Author

@dsherret yes I think that would work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants