Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize font sizes #105

Open
cmil opened this issue Oct 10, 2020 · 2 comments
Open

Harmonize font sizes #105

cmil opened this issue Oct 10, 2020 · 2 comments
Assignees

Comments

@cmil
Copy link
Member

cmil commented Oct 10, 2020

In the new design, I feel we use too many different font sizes (currently in index.css I find 24 different sizes: grep font-size src/index.css | sed 's/^ *//g' | sort | uniq | wc -l) and the differences in size are sometimes too extreme and.

I think we should try to balance this out a bit. Here are a few suggestions:

  • Settle for 4, maximum 5 different sizes
  • Reduce the size of titles and years in the corpus tables, the feel bigger than they need to be
  • The author name on play info pages, in my opinion, doesn't have the weight it deserves (it's font size is smaller than the subtitle).
  • The footer text on the home page should be bigger. This is important information, not just fine print. Especially on mobile screens it gets hard to read.
  • The text of corpus card data on mobile also feels a bit too small. Maybe increase the base font size on mobile in general.
  • The Navigation tabs on play info pages could use a bit more weight. In a way they are kind of subheadings indicating what kind of data is available.
  • The text for network metrics should have the same size as the cast list.
  • Try to take advantage of bootstraps base typography.
@cmil
Copy link
Member Author

cmil commented Jul 16, 2021

With an updated grep over the various *.scss files we now maintain I still count 24 different font-size declarations: grep -h '^ *font-size:' src/*.scss src/components/*.scss | sed 's/^ *//g' | sort | uniq. This doesn't necessarily mean we actually use 24 different sizes. But I would still like to consolidate this a bit more. We don't need to do this for the upcoming release, but I'd prefer to keep the ticket in the backlog.

@cmil
Copy link
Member Author

cmil commented Jul 16, 2021

Here is the output btw:

$ grep -h '^ *font-size:' src/*.scss src/components/*.scss | sed 's/^ *//g' | sort | uniq 
font-size: .85rem;
font-size: .8em;
font-size: .9em;
font-size: .9rem;
font-size: 0.6em;
font-size: 0.85em;
font-size: 0;
font-size: 1.2em;
font-size: 1.2rem;
font-size: 1.3em;
font-size: 1.3rem;
font-size: 1.5em;
font-size: 1.73em;
font-size: 1em;
font-size: 1rem;
font-size: 2.1em;
font-size: 2.5rem;
font-size: 20px;
font-size: 3em;
font-size: 3rem;
font-size: 60% !important;
font-size: 60%;
font-size: 85%;
font-size: calc(2.3 * var(--x)) !important;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant