Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link hint some time use default #12

Open
binhtran432k opened this issue Mar 4, 2022 · 3 comments
Open

The link hint some time use default #12

binhtran432k opened this issue Mar 4, 2022 · 3 comments

Comments

@binhtran432k
Copy link

I don't known why but link hint on my browser sometimes uses the default theme.
I must use the more specific css matching from other vimium theme to solve this problem.
This is my change:

/* Link hint boxes */
#vimiumHintMarkerContainer div.internalVimiumHintMarker, #vimiumHintMarkerContainer div.vimiumHintMarker {
  background: #282a36;
  font-size: 12px;
  border: 0.25em solid #ffb86c;
  border-radius: 0.34em;
  box-shadow: 0em 0.1em 0.6em 0.1em rgba(0, 0, 0, 0.4);
}

/* Link hint text */
#vimiumHintMarkerContainer div span {
  color: #f8f8f2;
  font-size: inherit;
  text-shadow: none;
}

/* Link hint matching characters */
#vimiumHintMarkerContainer div > .matchingCharacter ~ span {
  color: #6272a4;
}
@Trollwut
Copy link
Contributor

Trollwut commented Mar 4, 2022

Hey mate!

Thanks for your contributions! :)

Can you give me an example where it falls back to default?

Also in your code, if you write a letter, it would be better to color the written letter instead of the remaining ones. I think this is more intuitively for the user to distinct what he has pressed.

@binhtran432k
Copy link
Author

binhtran432k commented Mar 5, 2022

This is the default link hint, it occur when I open a browser (Brave):
image
If I refresh the page many times, it sometimes uses the theme correctly like this:
image
This means dracula theme css not working at all (May be it is outdated)

@Trollwut
Copy link
Contributor

Indeed. It seems like on first launch into a site, the default style is being used. Upon refreshing or clicking another page in this site, the custom CSS is being used.

I can reproduce that behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants