Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test manual ci with fallback branch in workflow #1274

Open
wants to merge 4 commits into
base: my-tasks-scaffold
Choose a base branch
from

Conversation

MattBudz
Copy link
Contributor

Summary

PoC for adding a fallback branch for rubocop to compare against when trigger CI manually.

Check List

- [ ] Added a CHANGELOG entry

@@ -32,6 +32,7 @@ jobs:
IS_MERGE: ${{ github.base_ref == '' }}
PREV_SHA: ${{ github.event.before }}
TARGET_BRANCH: ${{ github.base_ref }}
FALLBACK_BRANCH: 'origin/develop'
Copy link
Contributor

@caitmich caitmich Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is specifying origin needed since we have this check in rubocop-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants