Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Avatar preview sticky #34

Closed
andersonaddo opened this issue Jul 18, 2020 · 1 comment · May be fixed by #40
Closed

Make the Avatar preview sticky #34

andersonaddo opened this issue Jul 18, 2020 · 1 comment · May be fixed by #40
Labels
good first issue Good for newcomers

Comments

@andersonaddo
Copy link

Hi guys!
I love your product.
Do you think you guys could make the Avatar previewer sticky? It'd make the generator a more comfortable mobile experience since users wouldn't have to scroll up all the time too see how the different choices look on their character.
@pckilgore
Copy link
Contributor

Good idea! We'd welcome a pull request implementing this, it should not be too difficult, and may actually allow us to remove some unfortunate hacks with our PNG generator requiring the avatar to be on-screen to work correctly in many browsers.

@pckilgore pckilgore added the good first issue Good for newcomers label Jul 22, 2020
@luanraithz luanraithz mentioned this issue Oct 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added sticky position to avatar preview luanraithz/avatar-generator
3 participants
@peterpme @pckilgore @andersonaddo