address review: handle boolean cluster.mode, restore trailing newlines

Author: Vedant Madane

contrib/charts/dragonfly/templates/_pod.tpl

@@ -87,7 +87,13 @@ containers:
       {{- toYaml . | trim | nindent 6 }}
     {{- end }}
     {{- with .Values.cluster }}
-    {{- $clusterMode := printf "%v" (.mode | default "") }}
+    {{- $modeRaw := .mode | default "" }}
+    {{- $clusterMode := "" }}
+    {{- if kindIs "bool" $modeRaw }}
+      {{- if $modeRaw }}{{- $clusterMode = "yes" }}{{- end }}
+    {{- else }}
+      {{- $clusterMode = $modeRaw | toString }}
+    {{- end }}
     {{- if ne $clusterMode "" }}
       - "--cluster_mode={{ $clusterMode }}"
     {{- end }}
@@ -154,4 +160,4 @@ volumes:
   {{- toYaml . | trim | nindent 2 }}
 {{- end }}
 {{- end }}
-{{- end }}
+{{- end }}

contrib/charts/dragonfly/values.yaml

@@ -175,7 +175,8 @@ extraArgs: []
 
 cluster:
   # -- Redis cluster protocol mode passed to Dragonfly as --cluster_mode.
-  # -- Use "emulated" or "yes" (must be quoted in YAML to avoid boolean coercion).
+  # -- Accepts "emulated" or "yes". Unquoted `yes` (parsed as boolean by YAML)
+  # -- is also supported and treated as the string "yes".
   # -- Leave empty to disable cluster mode.
   mode: ""
   # -- When cluster mode is enabled, pass --experimental_cluster_shard_by_slot=true
@@ -232,4 +233,4 @@ tolerations: []
 affinity: {}
 
 # -- Topology Spread Constraints for pod assignment
-topologySpreadConstraints: []
+topologySpreadConstraints: []