Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement CLIENT SETINFO #3137

Closed
romange opened this issue Jun 6, 2024 · 0 comments · Fixed by #3673
Closed

implement CLIENT SETINFO #3137

romange opened this issue Jun 6, 2024 · 0 comments · Fixed by #3673
Assignees
@chakaz
Labels
enhancement New feature or request Next Up task that is ready to be worked on and should be added to working queue

Comments

@romange
Copy link
Collaborator

romange commented Jun 6, 2024

https://redis.io/docs/latest/commands/client-setinfo/

It's a noop in Dragonfly, but we should export a map of all libname:version via /metrics.
@romange romange added the enhancement New feature or request label Jun 6, 2024
@romange romange added the Next Up task that is ready to be worked on and should be added to working queue label Aug 31, 2024
chakaz added a commit that referenced this issue Sep 8, 2024
@chakaz
feat(server): Support CLIENT SETINFO
ce7bb5a 
Add support for `CLIENT SETINFO <LIB-NAME | LIB-VER>` and also return
that as part of `CLIENT LIST`, like Valkey.

Fixes #3137
@chakaz chakaz mentioned this issue Sep 9, 2024
Merged
chakaz added a commit that referenced this issue Sep 9, 2024
@chakaz
feat(server): Support CLIENT SETINFO (#3673)
b10a4a5 
Add support for `CLIENT SETINFO <LIB-NAME | LIB-VER>` and also return
that as part of `CLIENT LIST`, like Valkey.

Fixes #3137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakaz chakaz

Labels
enhancement New feature or request Next Up task that is ready to be worked on and should be added to working queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(server): Support CLIENT SETINFO dragonflydb/dragonfly
2 participants
@romange @chakaz