chore(tiering): Fixes #3225
Open
chore(tiering): Fixes #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Jun 26, 2024
src/server/tiering/disk_storage.h
Outdated
| @@ -19,6 +19,7 @@ class DiskStorage { | |||
| struct Stats { | |||
| size_t allocated_bytes = 0; | |||
| size_t capacity_bytes = 0; | |||
| size_t max_size = 0; | |||
There was a problem hiding this comment.
maybe add a comment explaining what it means
|
Will probably detect and add more after #3237 is resolved |
dranikpg
force-pushed
the
tiering-fixes
branch
2 times, most recently
from
0e9026c
to
8dddc17
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.