Put passwords in secrets instead of configmaps

[vflaux]

Bug report:

Redis & MySQL passwords are stored in Configmaps.

Expected behavior:

Password should be in Secrets.

How to reproduce it:

N/A

Environment:

• Dragonfly version: N/A
• OS: N/A
• Kernel (e.g. uname -a): N/A
• Others: N/A

[gaius-qi]

I think it's a good idea, you can try to support it.

[andrewrothstein]

this change requires a change to how the manager handles secrets. both the secret and the not-secret configuration parameters are comingled in the config file for the manager. I see u rejected #246. perhaps u can add some color as to why. unless the underlying system supports reading the secrets from somewhere not comingled with the not-secrets, the whole configuration should be treated like a secret.

I was looking at the code for the manager. are you open to a PR that reads these secrets as overrides from environment variables rather than exclusively from the config file? that will allow us to bring the secrets from a k8s Secret into the environment of the manager pods without disrupting the existing usage pattern.